Skip to content

Conversation

jrood
Copy link
Contributor

@jrood jrood commented Jul 31, 2025

Overview

FormError has been a wrapper around ErrorSpan that does nothing. We can export the styled.span directly as FormError.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

Copy link

nx-cloud bot commented Jul 31, 2025

View your CI Pipeline Execution ↗ for commit 1c71f50


☁️ Nx Cloud last updated this comment at 2025-07-31 22:27:57 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://688bedffea6db08ef539bf69--gamut-preview.netlify.app

Deploy Logs

@jrood jrood changed the title Simplify FormError fix(FormError): remove unnecessary wrapper Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants