feat(Anchor + Button): allow both leading and trailing icons #3141
+649
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 7e37ce1 ☁️ Nx Cloud last updated this comment at |
dreamwasp
reviewed
Aug 27, 2025
| export const InlineIcons: Story = { | ||
| render: () => ( | ||
| <FlexBox gap={16} row> | ||
| <FlexBox flexDirection={{ _: 'column', sm: 'row' }} gap={16}> |
There was a problem hiding this comment.
do these looks off to you? the arrows look top aligned
dreamwasp
reviewed
Sep 4, 2025
Comment on lines
107
to
109
| iconPosition: 'right', | ||
| iconAndTextGap: 16, | ||
| }); |
There was a problem hiding this comment.
nit: i'm sortof anti explicit style testing, but i think we can just think about cleaning these up when we eventually introduce visual testing
There was a problem hiding this comment.
Alrighties, I forgot about this tbh and some of the tests were AI-gen tbh
I did remove the ones related to spacing
but I kept the layout related ones, thoughts?
📬Published Alpha Packages:@codecademy/[email protected] |
|
🚀 Styleguide deploy preview ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the Anchor and Button components to allow both leading and trailing icons
PR Checklist
Testing Instructions
Don't make me tap the sign.
?path=/docs/typography-anchor--docs&globals=viewport:responsiveand scroll down to the "Icons" section?path=/docs/atoms-buttons-button--docsand scroll to the "Inline icons" section/?path=/docs/molecules-menu--docsPR Links and Envs