Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Format): run it #3008

Closed
wants to merge 1 commit into from
Closed

chore(Format): run it #3008

wants to merge 1 commit into from

Conversation

jrood
Copy link
Contributor

@jrood jrood commented Jan 16, 2025

Overview

No changes aside from running yarn format. We had a number of files that were apparently written prior to the current format configuration.

Copy link

nx-cloud bot commented Jan 16, 2025

View your CI Pipeline Execution ↗ for commit d9df27a.


☁️ Nx Cloud last updated this comment at 2025-01-16 17:13:17 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67893e4afa80be22b20ad910--gamut-preview.netlify.app

Deploy Logs

@jrood jrood marked this pull request as ready for review January 16, 2025 17:55
@jrood jrood requested a review from a team as a code owner January 16, 2025 17:55
@jakemhiller jakemhiller requested a review from dreamwasp January 16, 2025 19:13
Comment on lines +30 to +31
const { expandable, selectable, onSelect, onFilter, onSort, prefixId } =
useControlContext();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these fixes seems a little off to me (including this one). i'll take a look at what changed + chat with the broader web plat team, def something we just inadvertently changed during the gamut migration

Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make some adjustments to format rules, there were some inadvertent changes during the gamut migration

@jrood jrood closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants