Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): fix HTML semantics #2989

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
8716a24
remove styleguide
jakemhiller Jul 1, 2024
04ad77e
replace all usage of babel-preset-codecademy
jakemhiller Jul 1, 2024
8ea5743
add basic babel packages
jakemhiller Jul 1, 2024
3301b2b
ran nx migrate latest, update node
jakemhiller Jul 1, 2024
0915da7
ran migrations
jakemhiller Jul 1, 2024
e02961d
remove migrations file
jakemhiller Jul 1, 2024
d4a9dd4
fix all tests for newer react version
jakemhiller Jul 1, 2024
768a3b5
bump node in CI
jakemhiller Jul 1, 2024
3a908bb
fix build errors
jakemhiller Jul 2, 2024
81604da
Storybook 8 feature branch
dreamwasp Oct 14, 2024
ca64cba
Merge remote-tracking branch 'origin/main' into storybook-8
dreamwasp Oct 14, 2024
380714a
try resolving promise errors
dreamwasp Oct 14, 2024
07f770c
fix iconbutton test
dreamwasp Oct 14, 2024
4fe51b4
wipe out sb for now
dreamwasp Oct 14, 2024
96b8fd0
Merge remote-tracking branch 'origin/main' into storybook-8
dreamwasp Oct 16, 2024
41a5290
add node changes here
dreamwasp Oct 16, 2024
84e57ee
fix button test failure
dreamwasp Oct 16, 2024
c19dffb
fix this, what the heck
dreamwasp Oct 16, 2024
b3a29a6
gridform act fix
dreamwasp Oct 16, 2024
bc8c541
keep fixing acts
dreamwasp Oct 16, 2024
0483fdc
remove webpack here
dreamwasp Oct 16, 2024
17a12a2
Merge branch 'main' into storybook-8
aresnik11 Oct 22, 2024
f7ecdee
merge in dev
dreamwasp Nov 7, 2024
e176900
Merge branch 'main' into storybook-8
dreamwasp Nov 11, 2024
799b765
merge in dev
dreamwasp Nov 21, 2024
c3121dc
merge in dev
dreamwasp Dec 5, 2024
3e3f48e
start with empty lib (#2952)
dreamwasp Dec 9, 2024
44e7b76
yarn format fixes (#2987)
dreamwasp Dec 11, 2024
4b6df5c
fix(DataTable): fix HTML semantics
dreamwasp Dec 11, 2024
63ffd46
html semantics in better shape, need to test if renderExpanded is ess…
dreamwasp Dec 11, 2024
d14d96b
note to self
dreamwasp Dec 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gridform act fix
dreamwasp committed Oct 16, 2024
commit b3a29a64e288d4c8e480053aa79686fe255b0db4
16 changes: 8 additions & 8 deletions packages/gamut/src/GridForm/__tests__/GridForm.test.tsx
Original file line number Diff line number Diff line change
@@ -151,9 +151,8 @@ describe('GridForm', () => {
const { view } = renderView({ onSubmit });
const { checkboxField, selectField, textField } = getBaseCases(view);

doBaseFormActions(selectField, textField, checkboxField);

await act(async () => {
doBaseFormActions(selectField, textField, checkboxField);
fireEvent.submit(view.getByRole('button'));

await api.innerPromise;
@@ -491,12 +490,14 @@ describe('GridForm', () => {
const api = createPromise<{}>();
const onSubmit = async (values: {}) => api.resolve(values);

const { view } = renderView({ onSubmit, disableFieldsOnSubmit: true });
const { view } = await asyncRenderView({
onSubmit,
disableFieldsOnSubmit: true,
});
const { checkboxField, selectField, textField } = getBaseCases(view);

doBaseFormActions(selectField, textField, checkboxField);

await act(async () => {
doBaseFormActions(selectField, textField, checkboxField);
fireEvent.submit(view.getByRole('button'));
});

@@ -534,12 +535,11 @@ describe('GridForm', () => {
const api = createPromise<{}>();
const onSubmit = async (values: {}) => api.resolve(values);

const { view } = renderView({ onSubmit, resetOnSubmit: true });
const { view } = await asyncRenderView({ onSubmit, resetOnSubmit: true });
const { checkboxField, selectField, textField } = getBaseCases(view);

doBaseFormActions(selectField, textField, checkboxField);

await act(async () => {
doBaseFormActions(selectField, textField, checkboxField);
fireEvent.click(view.getByRole('button'));
});
const firstResult = await api.innerPromise;