[New Term] SQL: Drop Table #1455

kazumikerr · 2023-01-05T14:20:59Z

Description

Added a new term Drop Table for SQL documentation #1424

Type of Change

Adding a new entry

Checklist

All writings are my own.
My entry follows the Codecademy Docs style guide.
My changes generate no new warnings.
I have performed a self-review of my own writing and code.
I have checked my entry and corrected any misspellings.
I have made corresponding changes to the documentation if needed.
I have confirmed my changes are not being pushed from my forked main branch.
I have confirmed that I'm pushing from a new branch named after the changes I'm making.
Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

CLAassistant · 2023-01-05T14:21:08Z

All committers have signed the CLA.

SSwiniarski · 2023-01-05T17:13:41Z

@kazumikerr I'll be doing a first review on this. Please remember to sign the CLA

SSwiniarski

@kazumikerr I did a first review and left you a couple of comments.

content/sql/concepts/commands/terms/drop-table/drop-table.md

kazumikerr · 2023-01-06T14:19:33Z

@SSwiniarski I tried to run git push origin drop-table-branch and getting errors:

! [rejected] drop-table-branch -> drop-table-branch (non-fast-forward)
error: failed to push some refs to 'https://github.com/kazumikerr/docs.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I also ran git rebase main and response was

Current branch drop-table-branch is up to date.

Could you please help me when you have a chance? Thank you.

SSwiniarski · 2023-01-06T16:41:07Z

@Dusch4593, any ideas on @kazumikerr's problem?

Dusch4593 · 2023-01-06T22:58:06Z

@Dusch4593, any ideas on @kazumikerr's problem?

@kazumikerr From what I can tell, your remote's main branch is 1 commit behind the upstream Codecademy/docs:main base branch. Here's what I'd recommend for this:

Catch your origin/main branch up with Codecademy/docs:main on GitHub:

On your terminal, switch to your local main branch by running git checkout main
Run git pull to sync your local main with your remote origin/main
Switch back into this PR branch with git checkout drop-table-branch and run git pull again

If this takes you to a weird Vim-like screen on your terminal, you can exit it by typing :wq and pressing Enter

add/commit/push your changes like normal.

Hope this helps and let me know if you have any questions or run into any issues. 😄

cc: @SSwiniarski

kazumikerr · 2023-01-06T23:20:54Z

Thank you for your detailed explanations @Dusch4593 .

I followed your instructions and it was working fine until the step 5 git pull.

There is no tracking information for the current branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.
git pull <remote> <branch>
If you wish to set tracking information for this branch you can do so with:
git branch --set-upstream-to=<remote>/<branch> drop-table-branch

At step 6, commit command's response was:

On branch drop-table-branch
nothing to commit, working tree clean

git push origin drop-table-branch command's response was:

! [rejected] drop-table-branch -> drop-table-branch (non-fast-forward)
error: failed to push some refs to 'https://github.com/kazumikerr/docs.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

How would you suggest we proceed?

Dusch4593 · 2023-01-06T23:26:42Z

@kazumikerr Ah gotcha.

For step 5, try running with git pull origin main, instead. Then move to step 6 to see the push will work.

Hope this helps 😄

kazumikerr · 2023-01-07T00:23:49Z

Thank you, @Dusch4593.

After running the git pull origin main, I'm getting this message:

branch main -> FETCH_HEAD
hint: You have divergent branches and need to specify how to reconcile them.
hint: You can do so by running one of the following commands sometime before
hint: your next pull:
hint:
hint: git config pull.rebase false # merge
hint: git config pull.rebase true # rebase
hint: git config pull.ff only # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
fatal: Need to specify how to reconcile divergent branches.

I read this stack overflow post, but I was not sure how to proceed with this. Could you please help me when you have a chance? Thank you.

SSwiniarski

@kazumikerr Looks good for a second review.

kazumikerr · 2023-01-07T15:07:55Z

@Dusch4593
I'm not exactly sure how, but I think I could successfully push the drop-table-branch.

I ran following commands:
git pull origin drop-table-branch --rebase

warning: skipped previously applied commit 86a657b7
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config advice.skippedCherryPicks false"
Successfully rebased and updated refs/heads/drop-table-branch.

git push origin drop-table-branch

kazumikerr · 2023-01-07T15:10:59Z

@SSwiniarski
Thank you for reviewing so quickly! Is there anything I should do next?

SSwiniarski · 2023-01-07T15:49:35Z

@kazumikerr You don't need to do anything until another maintainer comes and does a second review.

kazumikerr · 2023-01-11T13:24:31Z

@SSwiniarski @Dusch4593
Is there anything I should do at this moment?

Dusch4593

Hey @kazumikerr! 👋🏻 I just had one point of feedback and then this should be good to merge afterward. 😄

Dusch4593 · 2023-01-11T15:17:17Z

content/sql/concepts/commands/terms/drop-table/drop-table.md

+  - 'paths/analyze-data-with-sql'
+---
+
+The **`DROP TABLE`** command deletes an existing table in a database.


Suggested change

The **`DROP TABLE`** command deletes an existing table in a database.

The **`DROP TABLE`** command deletes an existing table in a [database](https://www.codecademy.com/resources/docs/general/database).

kazumikerr · 2023-01-11T16:16:51Z

@Dusch4593
Thank you for your feedback! I just updated the drop-table.md.

Dusch4593

LGTM 👍🏻 Thanks @kazumikerr!

github-actions · 2023-01-11T16:29:49Z

👋 @kazumikerr
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

Dusch4593 · 2023-01-11T16:35:26Z

Congrats and thank you for contributing to Codecademy Docs, @kazumikerr! 🎊 🥳

The entry should now be live: https://www.codecademy.com/resources/docs/sql/commands/drop-table

Currently, your profile is anonymously listed on the entry page. To make it visible, you'll need to add your GitHub username to your Codecademy profile, log out of Codecademy, and log back in with your GitHub account:

Looking forward to your next Docs contribution! 😄

kazumikerr · 2023-01-11T16:57:08Z

Thank you so much @Dusch4593 !
It was pleasure working with you.
I will definitely try to contribute more codecademy docs.

kazumikerr · 2023-01-11T17:07:33Z

@Dusch4593
Sorry to bother you. I added my github account on my codecademy profile, logged out, and logged back in to the codecademy using github. However, it created a new account and the codecademy doc contributor icon was not updated. Do you know what I'm doing wrong?

Dusch4593 · 2023-01-11T17:09:02Z

@Dusch4593

Sorry to bother you. I added my github account on my codecademy profile, logged out, and logged back in to the codecademy using github. However, it created a new account and the codecademy doc contributor icon was not updated. Do you know what I'm doing wrong?

Oh that's weird. Can you provide me links to both Codecademy profiles, if possible?

kazumikerr · 2023-01-11T17:12:05Z

@Dusch4593
This is the main codecademy account: https://www.codecademy.com/profiles/kazumi_kerr
This is the one just created using github: https://www.codecademy.com/profiles/ruby0670160139
Thank you for your help.

Dusch4593 · 2023-01-11T17:13:47Z

Thanks @kazumikerr! If you don't mind, I'm gonna confer with my colleagues and share these links to learn of what's causing this and come up with how to go forward.

kazumikerr · 2023-01-11T17:14:21Z

Yes, please. Thank you again!

Dusch4593 · 2023-01-11T17:42:36Z

@kazumikerr quick question: Is the email the same for (a) your Codecademy profile, (b) the new, weird Codecademy profile, and (c) your GitHub account?

kazumikerr · 2023-01-11T18:06:22Z

@Dusch4593
(a) Codecademy profile is using a different email address
(b) the new, weird Codecademy profile and (c) GitHub account are using the same email address

Dusch4593 · 2023-01-11T18:32:20Z

@kazumikerr Thank you! I'm going to pass this info along to our engineers/customer service folks to investigate what might be going on.

kazumikerr · 2023-01-12T01:56:15Z

@Dusch4593

Sorry for bothering you again.
It seems like the anonymous icon was updated to the weird ruby0670160139 icon.

Would it be possible to link the codecademy docs to this account instead: https://www.codecademy.com/profiles/kazumi_kerr

If not possible, I just renamed the username from ruby0670160139 to kazumikerr. But it still shows a weird ruby0670160139 icon. https://www.codecademy.com/profiles/kazumikerr

Dusch4593 · 2023-01-12T18:20:30Z

cc: @awgraves Any thoughts on this? Is this just a matter of @kazumikerr assigning a consistent email between their GitHub and (two) Codecademy accounts?

awgraves · 2023-01-12T21:26:27Z

Hi @kazumikerr sorry about the trouble here - I went ahead and manually linked this for you.
Live doc

That second account that was created has also been removed now as well.

kazumikerr · 2023-01-13T04:34:42Z

Thank you so much for your help @awgraves @Dusch4593 !
Confirmed the changes you made for linking the codecademy doc with the correct account and removing the second account.

add drop-tabe.md file

09e1ce6

kazumikerr changed the title ~~[New Term] SQL: Drop Table #1424~~ [New Term] SQL: Drop Table Jan 5, 2023

SSwiniarski linked an issue Jan 5, 2023 that may be closed by this pull request

[Entry] SQL: Drop Table #1424

Closed

3 tasks

SSwiniarski added sql SQL entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jan 5, 2023

SSwiniarski self-assigned this Jan 5, 2023

Merge branch 'main' into drop-table-branch

88b0f7f

SSwiniarski suggested changes Jan 5, 2023

View reviewed changes

content/sql/concepts/commands/terms/drop-table/drop-table.md Show resolved Hide resolved

content/sql/concepts/commands/terms/drop-table/drop-table.md Show resolved Hide resolved

SSwiniarski added status: review 1️⃣ completed status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Jan 5, 2023

Merge branch 'main' into drop-table-branch

725a70b

Merge branch 'Codecademy:main' into drop-table-branch

06768cd

kazumikerr added 2 commits January 7, 2023 09:50

Merge branch 'Codecademy:main' into drop-table-branch

17da068

add syntax and example explanations

caf7a33

SSwiniarski approved these changes Jan 7, 2023

View reviewed changes

SSwiniarski added status: ready for next review and removed status: waiting for author labels Jan 7, 2023

Merge branch 'main' into drop-table-branch

1be7a77

Dusch4593 self-requested a review January 9, 2023 19:33

Dusch4593 self-assigned this Jan 9, 2023

Dusch4593 suggested changes Jan 11, 2023

View reviewed changes

Dusch4593 added status: waiting for author and removed status: ready for next review labels Jan 11, 2023

add database url

7509a14

Merge branch 'main' into drop-table-branch

5b4adba

Dusch4593 approved these changes Jan 11, 2023

View reviewed changes

Dusch4593 merged commit cd0ed49 into Codecademy:main Jan 11, 2023

kazumikerr deleted the drop-table-branch branch January 11, 2023 16:29

	The `DROP TABLE` command deletes an existing table in a database.
	The `DROP TABLE` command deletes an existing table in a [database](https://www.codecademy.com/resources/docs/general/database).

[New Term] SQL: Drop Table #1455

[New Term] SQL: Drop Table #1455

Uh oh!

Conversation

kazumikerr commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Uh oh!

CLAassistant commented Jan 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SSwiniarski commented Jan 5, 2023

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kazumikerr commented Jan 6, 2023

Uh oh!

SSwiniarski commented Jan 6, 2023

Uh oh!

Dusch4593 commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kazumikerr commented Jan 6, 2023

Uh oh!

Dusch4593 commented Jan 6, 2023

Uh oh!

kazumikerr commented Jan 7, 2023

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

kazumikerr commented Jan 7, 2023

Uh oh!

kazumikerr commented Jan 7, 2023

Uh oh!

SSwiniarski commented Jan 7, 2023

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 left a comment

Choose a reason for hiding this comment

Uh oh!

Dusch4593 Jan 11, 2023

Choose a reason for hiding this comment

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 11, 2023

Uh oh!

Dusch4593 commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 commented Jan 11, 2023

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 commented Jan 11, 2023

Uh oh!

kazumikerr commented Jan 11, 2023

Uh oh!

Dusch4593 commented Jan 11, 2023

Uh oh!

kazumikerr commented Jan 12, 2023

kazumikerr commented Jan 5, 2023 •

edited

Loading

CLAassistant commented Jan 5, 2023 •

edited

Loading

Dusch4593 commented Jan 6, 2023 •

edited

Loading

Dusch4593 commented Jan 11, 2023 •

edited

Loading

Dusch4593 commented Jan 11, 2023 •

edited

Loading