Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Revise and Reorder JS3 1 and 2 #405

Merged
merged 22 commits into from
Nov 28, 2023

Conversation

SallyMcGrath
Copy link
Member

What does this change?

Module: JS3
Week(s): 1, 2

Checklist

Description

I have revised week 1 to remove innerHTMl. To make this readable I have introduced template HTML. To follow on with this, I've moved week 3 to week2 as per the discussion here #315

They define a template, they define a state object, they update the state based on interactions, the UI reacts to the state -- the UI is a function of the state

It's going to be taught really soon so this will have to be deployed this week regardless and revisions will be done on the deployed pages.

Who needs to know about this?

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 3735943
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/65666b9226870d0008256301
😎 Deploy Preview https://deploy-preview-405--cyf-curriculum.netlify.app/js3/sprints/1/prep
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 91 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

I've moved Technical writing to stretch and highlighted it here
rm headings, add emojis, condense a bit
I feel like Daniel already did some of this but it's not in here
@SallyMcGrath SallyMcGrath mentioned this pull request Nov 28, 2023
5 tasks
@SallyMcGrath
Copy link
Member Author

mini consultation done - we decided to merge and revise after as the deadline is TIGHT

@SallyMcGrath SallyMcGrath merged commit 6fbc97c into main Nov 28, 2023
@SallyMcGrath SallyMcGrath deleted the content/js3/reorder-revise1-2 branch November 28, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant