-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: Revise and Reorder JS3 1 and 2 #405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's some kind of formatting fail in here breaking everything
For some reason codemirror is just completely crapping out
REVERT THIS
revision with template HTML to blend with S2
include the GWT framing from S1
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I've moved Technical writing to stretch and highlighted it here
rm headings, add emojis, condense a bit
I feel like Daniel already did some of this but it's not in here
mini consultation done - we decided to merge and revise after as the deadline is TIGHT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Module: JS3
Week(s): 1, 2
Checklist
Description
I have revised week 1 to remove innerHTMl. To make this readable I have introduced template HTML. To follow on with this, I've moved week 3 to week2 as per the discussion here #315
They define a template, they define a state object, they update the state based on interactions, the UI reacts to the state -- the UI is a function of the state
It's going to be taught really soon so this will have to be deployed this week regardless and revisions will be done on the deployed pages.
Who needs to know about this?