-
-
Notifications
You must be signed in to change notification settings - Fork 115
Feature: Add printable Book layout, print stylesheet and sample chapters (#127)Feature/pdf book #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-curriculum pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I took a look at this, and I'm not sure it's quite solving the right problem here. We want to make it so that all of the existing content of the course can easily be printed. So on the This looks like it's instead creating a new section of the guides repo which adds brand new (placeholder) content. Ideally e.g. if I go to https://deploy-preview-1636--cyf-programming.netlify.app/book/ it would show the whole course as one page (either as HTML that will print conveniently to a PDF, or as a PDF itself generated at build time). |
|
“Hi! My PR’s deploy preview (#1636) is pending review in Netlify (cyf-piscine). Could someone please approve it so I can verify the Book layout changes?” |
|
All of our sites work the same. I allowed one of the deploy previews (see #1636 (comment)) which you can use, but I'd recommend developing locally and verifying things there (see instructions in https://github.com/CodeYourFuture/curriculum/blob/main/CONTRIBUTING.md) rather than trying to iterate on GitHub. |

Overview
Adds a printable "Book" layout and supporting print stylesheet for the curriculum guides.
Changes
layouts/_default/book.htmlassets/css/book-print.cssandprint.csscontent/book/_index.mdWhy
This makes the site’s guides printable and lays the groundwork for generating PDFs.
Fixes #127