Updating "Using Git" workshop #1605
Conversation
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
This is all looking great, thanks!
One question - do you want the trainees to have permission to add labels? They should all be in a GitHub team because they should have completed CodeYourFuture/Module-Welcome#2 the sprint before (and long-term, we want to automate that). I ask because I've seen value both ways - I've seen value in them not being able to add labels (because it prompts an interesting discussion of permissions / ownership) but if so we maybe want to hint at it in the workshop. And I've seen value in them being able to add labels (it's good practice!) but if so we should add "ITP Trainees" as either "Triage" or "Request Code Review" access in https://github.com/CodeYourFuture/github_issues_prs_practice/settings/access
| There are three activities. Split into groups of no more than 5 and set a timer so you don't lose track of time. | ||
|
|
||
|
|
||
| > [!NOTE] |
There was a problem hiding this comment.
We're in a bit of a transitionary state with note-shaped things...
We have our own custom tag for this: {{<note type="exercise">}} where we can attach different titles and emoji to the title of the note.
GitHub recently added [!NOTE] and a few other directives, but they don't allow any customisation of the title. This styles exactly the same as a {{<note>}} without a type. We generally use the GitHub ones ([!NOTE], [!WARNING], etc) when we want exactly that heading, and our own when we want a different one.
I'd suggest here we want to do one of three things:
- Switch to a
{{<note type="exercise">}}so we get an "exercise" heading instead of a "Note" one. - Switch to a
{{<note type="exercise" title="Exercise 1: Eat Me, Drink Me 📚 (10 minutes)">}}and drop the##title, so the title appears as a naturally styled title in the block. - Make
{{<note>}}without atypeattribute just do the box-styling without adding a title, and leave the##title as-is.
I think I have a preference for 2 or 3, because I don't think the duplicate "exercise" title and "Exercise 1: ..." title are valuable
| Popcorn round your group and share one key takeaway | ||
|
|
||
| > [!NOTE] | ||
| > ## Exercise 3: Pull the Other One 🕵️ (20 minutes) |
There was a problem hiding this comment.
When I've run this workshop in the past, people have generally gotten confused by this heading and asked about :)
| > ## Exercise 3: Pull the Other One 🕵️ (20 minutes) | |
| > ## Exercise 3: Pull Requests 🕵️ (20 minutes) |
|
|
||
| Write your key takeaway down in your notebook. | ||
|
|
||
| ## Solo Challenge: Hidden Powers 🔮 (5 minutes) |
There was a problem hiding this comment.
Should this be styled as an exercise?
There was a problem hiding this comment.
Let's rename this directory to using-github-workshop or similar?
What does this change?
This incorporates the contents of the Developer-Specs repo into curriculum, and makes some changes to the content of the workshop.
In this repo:
common-content/blocks/developer-specsIn the workshop:
Common Content?
Common Theme?
Issue number: N/A
Org Content?
Sprint | Block
Checklist
Who needs to know about this?