This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
Requirements Patches, Workflow Concurrency, Error Messaging, and Test Coverage #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FLRota FYI. |
bwdmonkey
approved these changes
Jan 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the first batch of requirements updates, targeting the latest patch releases of the earliest versions of the requirements that support Python 3.9. Comments are added to help this update effort move forward. These updates required adding the
libcairo2-devpackage to the dev container.The
deploymentworkflow is updated to run its formatting, linting, and testing jobs concurrently, which reduced the runtime by about 66%. This inspired some minor tweaks to theMakefiletargets to support more granular setups.ViewsTestCase.test_download_receiptis expanded to test state polling.ViewsTestCase.test_poll_stateis added to include extra coverage.Various view functions are updated with less ambiguous error messaging.
The
make codespacetarget is updated to only initialize a database if one does not already exist.