BREAKING: Accept more truthy values for options and reject invalid ones #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br-lewis
approved these changes
Aug 8, 2023
All of `true`, `on`, `yes`, `y`, and `1` are now recognized as boolean values indicating `true` when passed to boolean options. If the value of a boolean option is neither of those nor any of the corresponding "falsy" values, an error is reported instead of silently accepting the value and interpreting it as `false`. Note: This change is mildly breaking as it should only break fuzzer invocations that weren't behaving as intended.
fmeum
force-pushed
the
FUZZ-778-accept-0-1-boolean
branch
from
d0e941b to
63e543e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of
true,on,yes,y, and1are now recognized as boolean values indicatingtruewhen passed to boolean options. If the value of a boolean option is neither of those nor any of the corresponding "falsy" values, an error is reported instead of silently accepting the value and interpreting it asfalse.Note: This change is mildly breaking as it should only break fuzzer invocations that weren't behaving as intended.