-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for debug builds of the fuzzer #660
Open
br-lewis
wants to merge
14
commits into
main
Choose a base branch
from
enable-debug-fuzzer-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to remove some debugging stuff before review but only after I make sure it actually passes CI. |
bertschneider
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new build target to the fuzzer package,
build:dev
, which will build the fuzzer with a debug configuration. It also renames theprebuild
target toprepack
becauseprebuild
will run prior tobuild
which means that the call toprebuild
will result in the cmake call inbuild
seeing that things are already built and not doing anything.While this could be handled by a
prebuild:dev
script that doesn't use--strip
, the other problem is thatprebuild
(the binary, not the script), will look to see if its output tarball already exists and refuses to continue if all you've changed is the build config and no actual code. That's why I chose to have more of this process go throughbuild
and leftprebuild
to be part of ourprerelease
pipeline.