Skip to content

Bump django-oauth-toolkit from 1.7.1 to 2.0.0 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump django-oauth-toolkit from 1.7.1 to 2.0.0 #387

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 26, 2022 •
edited
Loading

Bumps django-oauth-toolkit from 1.7.1 to 2.0.0.

Release notes

Sourced from django-oauth-toolkit's releases.

Release 2.0.0

What's Changed

New Contributors

Full Changelog: jazzband/django-oauth-toolkit@1.7.0...2.0.0

Changelog

Sourced from django-oauth-toolkit's changelog.

[2.0.0] 2022-04-24

This is a major release with BREAKING changes. Please make sure to review these changes before upgrading:

Added

Changed

  • #1129 (Breaking) Changed default value of PKCE_REQUIRED to True. This is a breaking change. Clients without PKCE enabled will fail to authenticate. This breaks with section 5 of RFC7636 in favor of the OAuth2 Security Best Practices for Authorization Code Grants. If you want to retain the pre-2.x behavior, set PKCE_REQUIRED = False in your settings.py
  • #1093 (Breaking) Changed to implement hashed client_secret values. This is a breaking change that will migrate all your existing cleartext application.client_secret values to be hashed with Django's default password hashing algorithm and can not be reversed. When adding or modifying an Application in the Admin console, you must copy the auto-generated or manually-entered client_secret before hitting Save.
  • #1108 OIDC: (Breaking) Add default configurable OIDC standard scopes that determine which claims are returned. If you've customized OIDC responses and want to retain the pre-2.x behavior, set oidc_claim_scope = None in your subclass of OAuth2Validator.
  • #1108 OIDC: Make the access_token available to get_oidc_claims when called from get_userinfo_claims.
  • #1132: Added --algorithm argument to createapplication management command

Fixed

  • #1108 OIDC: Fix validate_bearer_token() to properly set request.scopes to the list of granted scopes.
  • #1132: Fixed help text for --skip-authorization argument of the createapplication management command.

Removed

  • #1124 (Breaking, Security) Removes support for insecure urn:ietf:wg:oauth:2.0:oob and urn:ietf:wg:oauth:2.0:oob:auto which are replaced by RFC 8252 "OAuth 2.0 for Native Apps" BCP. Google has deprecated use of oob with a final end date of 2022-10-03. If you still rely on oob support in django-oauth-toolkit, do not upgrade to this release.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies python Pull requests that update Python code labels Apr 26, 2022
@kilemensi
Copy link
Member

I think we'd need to review this in detail @esirK to see if this version breaks anything.

@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 2 times, most recently from 50761b2 to 3f6bd27 Compare April 29, 2022 10:23
@kilemensi kilemensi self-assigned this Apr 29, 2022
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from 77b21d2 to ded2f8c Compare May 9, 2022 11:16
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from 7a583b4 to 248b763 Compare May 16, 2022 10:39
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from 79096c6 to 49a12c3 Compare May 23, 2022 12:25
@esirK
Copy link
Contributor

esirK commented May 24, 2022 •
edited
Loading

ola @kilemensi
I did some digging on this and this will break our applications since we are using Swappable Application here's such an issue.
I think the best way forward would be to wait/contribute a fix? Or what do you think?

@kilemensi
Copy link
Member

ola @kilemensi I did some digging on this and this will break our ...

💯 @esirK . Good catch.

@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from 864a3f3 to 993911e Compare May 30, 2022 14:06
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 2 times, most recently from 95a7657 to c5e4172 Compare June 2, 2022 10:06
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from f083f02 to 5121da3 Compare June 10, 2022 09:15
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 5 times, most recently from 69b23b1 to 30c57db Compare June 17, 2022 13:40
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch 3 times, most recently from 8e432bc to 29f8987 Compare June 22, 2022 05:57
@dependabot
Bump django-oauth-toolkit from 1.7.1 to 2.0.0
8f4fd35 
Bumps [django-oauth-toolkit](https://github.com/jazzband/django-oauth-toolkit) from 1.7.1 to 2.0.0.
- [Release notes](https://github.com/jazzband/django-oauth-toolkit/releases)
- [Changelog](https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md)
- [Commits](jazzband/django-oauth-toolkit@1.7.1...2.0.0)

---
updated-dependencies:
- dependency-name: django-oauth-toolkit
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/django-oauth-toolkit-2.0.0 branch from 29f8987 to 8f4fd35 Compare June 22, 2022 14:12
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 24, 2022

Superseded by #459.

@dependabot dependabot bot closed this Jun 24, 2022
@dependabot dependabot bot deleted the dependabot/pip/django-oauth-toolkit-2.0.0 branch June 24, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kilemensi kilemensi

Labels
dependencies python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilemensi @esirK