Slack notification after 30min of scraping #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andela-ookoro. Let's use this in the requirements https://github.com/CodeForAfricaLabs/python-slack-logger |
andela-ookoro
force-pushed
the
slackNotification
branch
from
47ad046
to
12c23e2
Compare
|
Welcome @DavidLemayian, I have replaced the existing slack handler package with slack-logger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add an enhancement to the project, it sends notifications to a targeted slack webhook when scraping takes longer than 30 minutes.
Two notifications would be sent, the first notification tells us that a scraper is running for more than 30 minutes, then another when the scarping has finished (this would help us know the total time scraping took).
I replaced the package
python-memcached==1.58withpython3-memcached== 1.51since the former did not work on python3 ( worked on local but failed on morph.io). Here is a link to this changes on morphFixes # (issue)
#44
Type of change
Enhancement
Screenshots
Notification that a scraper is running for more 30 minutes
Notification that a scraper ran for more 30 minutes