Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix First Responder Issues, Fix Custom Undo Manager #12

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

thecoolwinter
Copy link
Contributor

Description

Fixes the case where clicking on the view would not give the text view first responder status. This was because hitTest was returning the cursor view or a line fragment view, each of which should be transparent to responder or hitTest checks. This is fixed by returning self from TextView.hitTest if a line fragment or cursor view would normally be returned.

Also fixes an issue with setting a custom CEUndoManager on the text view.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
@thecoolwinter thecoolwinter merged commit 6abce20 into CodeEditApp:main Dec 23, 2023
2 checks passed
@thecoolwinter thecoolwinter deleted the responder branch December 23, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants