Improved Line Number Appearance #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
matthijseikelenboom,
lukepistrol and
thecoolwinter
thecoolwinter
requested changes
Oct 3, 2022
lukepistrol
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overall appearance of the line numbers in the gutter of the editor.
Related Issue
Before
Target
After
It is not perfect though, it needs decreased tracking and narrower character width. This is the code I have added to produce this:
It also uses character variants here such as the open "4" (you'll see in the target it is open, and in my version it is closed).
If anyone knows of a way to improve this let me know, otherwise we can merge this for the time being until we find a better solution.