Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CaptureModifierSet.insert #281

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fix CaptureModifierSet.insert #281

merged 2 commits into from
Dec 19, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Fixes a typo in CaptureModifierSet that &='s the rawValue when inserting instead of |=.
  • Adds tests for the same type.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 16, 2024
@thecoolwinter thecoolwinter merged commit b0688fa into CodeEditApp:main Dec 19, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/capturemodifier branch December 19, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecoolwinter @FastestMolasses