TreeSitterClient Highlight Responsiveness

[thecoolwinter]

Description

• Fixes an issue where tree sitter edits would call their completion handler while the lock on the executor was still held, causing the next (should be sync) operation to be forced async. This led to all highlights being executed asynchronously.
  • The fix is to do the operation on the tree-sitter state using the executor, and then call the completion once that value is held. The highlighter can then query for syntax highlights and the executor is freed to execute them synchronously.
  • This does not effect async operations, just an improvement for synchronous operations.

Related changes:

• Removed a redundant piece of code and replaced it with an existing helper function.
• Makes the invalidation of highlighted code explicit. Sometimes highlights can be missed by the layout manager so making the layout of the highlighted ranges explicit removes that possibility.

Related Issues

None.

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Before

Screen.Recording.2024-10-12.at.2.43.56.PM.mov

After

Screen.Recording.2024-10-12.at.2.35.14.PM.mov

[austincondiff]

Wow, I didn't realize highlights were asynchronous, nice improvement!