Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ruler look more like Xcode. #163

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Make ruler look more like Xcode. #163

merged 2 commits into from
Mar 16, 2023

Conversation

Eliulm
Copy link
Contributor

@Eliulm Eliulm commented Mar 16, 2023 •
edited by austincondiff
Loading

Description

  1. Add 20 pixels of inset to the left of the ruler and 8 pixels of inset to the right of the ruler. I tried to match it as close as possible to Xcode.
  2. Set the background color of the highlight ruler line to the same color as the highlighted line in the textView.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screenshot 2023-03-16 at 19 05 59

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 16, 2023 •
edited
Loading

@Eliulm Looks good! Please comment on both of the related issues so I can assign them to you.

@austincondiff austincondiff mentioned this pull request Mar 16, 2023
Closed
@thecoolwinter thecoolwinter merged commit 4ff2df5 into CodeEditApp:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@lukepistrol lukepistrol lukepistrol approved these changes

@austincondiff austincondiff Awaiting requested review from austincondiff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Padding to the left of line numbers ✨ Line highlight should appear behind ruler
4 participants
@Eliulm @austincondiff @lukepistrol @thecoolwinter