Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Commenting out code limited to only a single line #253

Closed
austincondiff opened this issue Jun 24, 2024 · 0 comments · Fixed by #261
Closed

🐞 Commenting out code limited to only a single line #253

austincondiff opened this issue Jun 24, 2024 · 0 comments · Fixed by #261
Assignees
@tom-ludwig
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Jun 24, 2024 •
edited
Loading

Description

Selecting multiple lines and pressing ⌘ / results in only the first line getting commented out.

To Reproduce

  1. Select multiple lines
  2. Press ⌘ /
  3. Notice only the first line is commented out

Expected Behavior

All the selected lines should be commented out.
@austincondiff austincondiff added the bug Something isn't working label Jun 24, 2024
@tom-ludwig tom-ludwig self-assigned this Aug 20, 2024
@tom-ludwig tom-ludwig mentioned this issue Aug 20, 2024
Merged
6 tasks
austincondiff pushed a commit that referenced this issue Aug 23, 2024
@tom-ludwig
fix(comments): Add Support for Commenting Multiple Lines (#261)
515b025 
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will
be closed until separated. -->

### Description
This PR lets you highlight multiple lines and comment them all out at
once.


### Related Issues
* closes #253 
<!--- REQUIRED: Tag all related issues (e.g. * #123) -->
<!--- If this PR resolves the issue please specify (e.g. * closes #123)
-->
<!--- If this PR addresses multiple issues, these issues must be related
to one other -->


### Checklist

<!--- Add things that are not yet implemented above -->

- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots


https://github.com/user-attachments/assets/97ae52d5-0fb0-4b25-90e6-2bbc18769856

<!--- REQUIRED: if issue is UI related -->

<!--- IMPORTANT: Fill out all required fields. Otherwise we might close
this PR temporarily -->
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom-ludwig tom-ludwig

Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(comments): Add Support for Commenting Multiple Lines CodeEditApp/CodeEditSourceEditor
2 participants
@austincondiff @tom-ludwig