Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Some theme colors only apply after changing theme #227

Closed
austincondiff opened this issue Jan 25, 2024 · 1 comment · Fixed by #230
Closed

🐞 Some theme colors only apply after changing theme #227

austincondiff opened this issue Jan 25, 2024 · 1 comment · Fixed by #230
Assignees
@thecoolwinter
Labels
bug Something isn't working

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Jan 25, 2024 •
edited
Loading

Description

Some colors from the selected theme are not applied to the editor until changing your theme.

To Reproduce

  1. Open editor
  2. Notice current line highlight color is wrong
  3. Open theme settings
  4. Change theme to something else, then back to original theme
  5. Notice the current line highlight color is now correct

Expected Behavior

The current line color should use the color specified in the theme.

Screenshots

Screen.Recording.2024-01-25.at.1.17.54.PM.mov
@austincondiff austincondiff added the bug Something isn't working label Jan 25, 2024
@thecoolwinter
Copy link
Collaborator

@austincondiff have you noticed any other theme colors not being applied initially?

@thecoolwinter thecoolwinter self-assigned this Feb 5, 2024
@thecoolwinter thecoolwinter mentioned this issue Feb 5, 2024
Merged
6 tasks
thecoolwinter added a commit that referenced this issue Feb 5, 2024
@thecoolwinter
(fix:#227) Apply Theme Selection Color (#230)
0816105
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Complete in CodeEdit Project Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thecoolwinter thecoolwinter

Labels
bug Something isn't working
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fix:#227) Apply Theme Selection Color thecoolwinter/CodeEditSourceEditor
2 participants
@austincondiff @thecoolwinter