Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Popovers #1922

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Instant Popovers #1922

merged 1 commit into from
Nov 2, 2024

Conversation

Kihron
Copy link
Contributor

@Kihron Kihron commented Oct 27, 2024

Description

  • Added a new custom view modifier which displays popovers instantly. As such, existing popovers have been updated, making the UI feel a bit more responsive.

Related Issues

  • None

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-10-27.at.12.19.09.AM.mov

@Kihron
- Added a custom view modifier to display popovers without animations
85dc011 
- Updated existing popovers to use the new instant popover modifier
austincondiff
austincondiff approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@austincondiff austincondiff merged commit ffb0f8b into CodeEditApp:main Nov 2, 2024
2 checks passed
@Kihron Kihron deleted the design/instant-popovers branch November 2, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@FastestMolasses FastestMolasses FastestMolasses approved these changes

@lukepistrol lukepistrol Awaiting requested review from lukepistrol

@MarcoCarnevali MarcoCarnevali Awaiting requested review from MarcoCarnevali

@thecoolwinter thecoolwinter Awaiting requested review from thecoolwinter

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kihron @austincondiff @FastestMolasses