Fix: Validate filenames consisting solely of extensions #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 8, 2024 20:00
… '.gitignore', '.editorconfig')
…s with a ".", every component will be checked to get a valid type.
…s with a ".", every component will be checked to get a valid type.
0xWDG
previously approved these changes
Jul 10, 2024
nanashili
reviewed
Jul 10, 2024
thecoolwinter
requested changes
Jul 10, 2024
There was a problem hiding this comment.
This looks good to me, there is one edge case created by taking the first result. For instance this file should be a yaml file icon. Could you reverse the check? So we first check if there's a valid file extension, then do your check for the prefixed filename. Then if that all fails we do a txt file.
|
@thecoolwinter Working on it! |
added 2 commits
July 10, 2024 17:38
#Conflicts: # CodeEdit/Features/CEWorkspace/Models/CEWorkspaceFile.swift
thecoolwinter
requested review from
austincondiff,
matthijseikelenboom,
bombardier200,
thecoolwinter and
tom-ludwig
bombardier200
approved these changes
Jul 11, 2024
|
@allcontributors please add @LeonardoLarranaga for code |
|
I've put up a pull request to add @LeonardoLarranaga! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves an issue where supported files with only extensions (e.g., .env, .gitignore) were not displaying their correct icons.
Related Issues
Checklist
Screenshots
Before:
After: