Allow text files to be edited even when empty #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
requested changes
May 19, 2024
|
I'll close #1723 in favor of working on it here, it clearly doesn't solve the entire problem. |
|
The previous commit works as expected. I made the document's There is a helper |
markgravity
reviewed
May 22, 2024
- CodeEditTextView 0.7.3 -> 0.7.4 - CodeEditSourceEditor 0.7.2 -> 0.7.3 - CodeEditLanguages 0.1.18 -> 0.1.19
…llow-edit-text-file-when-contents-in-empty
Only check for when `CodeFileDocument.content` is not nil. If the content is an empty string, it means we're viewing an empty text file, which is a predictable behavior. Also, the extra checks cause unexpected behaviors. Check the related pull request (CodeEditApp#1724) for visuals.
|
Showing the visuals for 45c39ce WITH EXTRA CHECKS: specific-non-empty-files-open-with-quicklook.movThe affected files are same as in #1722 (comment)
WITHOUT THE EXTRA CHECKS: predictable-behavior-so-far.mov |
…llow-edit-text-file-when-contents-in-empty Why merge conflicts????
thecoolwinter
previously approved these changes
Jun 19, 2024
austincondiff
previously approved these changes
Jun 19, 2024
…llow-edit-text-file-when-contents-in-empty
thecoolwinter
approved these changes
Jun 21, 2024
…llow-edit-text-file-when-contents-in-empty
thecoolwinter
approved these changes
Jun 22, 2024
bombardier200
approved these changes
Jun 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done by making sure the opened file can be encoded as text.
Has been tested against a plethora of file types.
Related Issues
Checklist
Screenshots
allow-text-files-to-be-edited-even-when-empty.mov