Code

Correctly preview non-text files#1707

Code

Merged

austincondiff merged 66 commits intoCodeEditApp:mainCodeEditApp/CodeEdit:mainfrom plbstl:view-non-text-files-correctlyplbstl/CodeEdit:view-non-text-files-correctlyCopy head branch name to clipboardMay 11, 2024

+371-352

Commits

Commits on May 7, 2024

• Package.resolved changed

  plbstl

  committed
  6f30d92

  Copy full SHA for 6f30d92

• progress

  plbstl

  committed
  7113389

  Copy full SHA for 7113389

• minor doc change in CodeEditUI EffectView

  plbstl

  committed
  9a85005

  Copy full SHA for 9a85005

• add WorkspacePdfFileView

  plbstl

  committed
  6749915

  Copy full SHA for 6749915

• allow WorkspacePdfFileView to be able to send data to SwiftUI

  plbstl

  committed
  3d3893e

  Copy full SHA for 3d3893e

Commits on May 8, 2024

• properly name WorkspacePdfFileView to WorkspacePDFView

  plbstl

  committed
  bd3fe37

  Copy full SHA for bd3fe37

• improve WorkspacePDFView docs

  plbstl

  committed
  a12e51c

  Copy full SHA for a12e51c

• add guards to WorkspacePDFView (makeNSView, updateNSView)

  plbstl

  committed
  2b59534

  Copy full SHA for 2b59534

• wip

  plbstl

  committed
  6797552

  Copy full SHA for 6797552

• wip 2

  plbstl

  committed
  15291c0

  Copy full SHA for 15291c0

• correct padding

  plbstl

  committed
  2fd13b4

  Copy full SHA for 2fd13b4

• progress? not

  plbstl

  committed
  7ae71a0

  Copy full SHA for 7ae71a0

Commits on May 9, 2024

• add attachPDFDocumentToView helper in WorkspacePDFView

  plbstl

  committed
  ff47ae8

  Copy full SHA for ff47ae8

• update WorkspacePDFView docs

  plbstl

  committed
  d820eb9

  Copy full SHA for d820eb9

• remove WorkspaceNonTextFileView

  plbstl

  committed
  b5f1614

  Copy full SHA for b5f1614

• fix SwiftLint violations in WorkspacePDFView, WorkspaceCodeFileView

  plbstl

  committed
  7ef3116

  Copy full SHA for 7ef3116

• add magic numbers comment to WorkspaceCodeFileView

  plbstl

  committed
  6d7f7d8

  Copy full SHA for 6d7f7d8

• update WorkspacePDFView docs

  plbstl

  committed
  2192c70

  Copy full SHA for 2192c70

• before i forget

  plbstl

  committed
  74cd22b

  Copy full SHA for 74cd22b

• progressss

  plbstl

  committed
  8ef8461

  Copy full SHA for 8ef8461

• too slow

  plbstl

  committed
  a643b43

  Copy full SHA for a643b43

• wip: the best work yet

  plbstl

  committed
  f583df0

  Copy full SHA for f583df0

• it really works!!

  plbstl

  committed
  410f62d

  Copy full SHA for 410f62d

• add WorkspaceImageView

  plbstl

  committed
  b80dc31

  Copy full SHA for b80dc31

• add WorkspaceCannotPreviewFileView

  plbstl

  committed
  a9ed5ad

  Copy full SHA for a9ed5ad

• its working very predictably but showing/hiding navigator pane isn't smooth

  plbstl

  committed
  ff57cc8

  Copy full SHA for ff57cc8

• remove the use of canPreview as it can cause unexpected behaviour

  plbstl

  committed
  1813416

  Copy full SHA for 1813416

• remove computeFrame helper in WorkspaceCodeFileView

  plbstl

  committed
  6106b64

  Copy full SHA for 6106b64

• update PDF preview's background color

  plbstl

  committed
  dc7bcad

  Copy full SHA for dc7bcad

• add note for when PDF preview cannot create PDF document

  plbstl

  committed
  2e4dd02

  Copy full SHA for 2e4dd02

• improve docs for WorkspaceImageView & WorkspacePDFView

  plbstl

  committed
  c2fcacc

  Copy full SHA for c2fcacc

• use unnamed parameter for imageUrl in WorkspaceImageView

  plbstl

  committed
  2d448f6

  Copy full SHA for 2d448f6

• implement WorkspaceCannotPreviewFileView

  plbstl

  committed
  f2ca164

  Copy full SHA for f2ca164

• change url variables in WorkspaceImageView, WorkspacePDFView & WorkspaceCannotPreviewFileView to private

  plbstl

  committed
  c248a9d

  Copy full SHA for c248a9d

• add WorkspaceLoadingView

  plbstl

  committed
  82ef086

  Copy full SHA for 82ef086

• spacing violation

  plbstl

  committed
  eb15141

  Copy full SHA for eb15141

• change onAppear modifier in WorkspaceCannotPreviewFileView

  plbstl

  committed
  d32436a

  Copy full SHA for d32436a

• remove WorkspaceCannotPreviewFileView as it creates a bug that makes thumbnailing slightly unpredictable

  Show description for 4238f2c
  plbstl

  committed
  4238f2c

  Copy full SHA for 4238f2c

• improve docs in WorkspacePDFView & WorkspaceImageView

  plbstl

  committed
  5c5c81b

  Copy full SHA for 5c5c81b

• use WorkspaceAnyFileView to preview GIF images

  plbstl

  committed
  752fe3b

  Copy full SHA for 752fe3b

• add a note to the documentation for CodeFileDocument.utType

  plbstl

  committed
  40d52c6

  Copy full SHA for 40d52c6

• add WorkspaceAnyFileView to properly preview files of different file types

  plbstl

  committed
  b24b6ff

  Copy full SHA for b24b6ff

• rearrange files in CodeEdit/Features/Documents/Views

  plbstl

  committed
  d2664bd

  Copy full SHA for d2664bd

• add WorkspaceAnyFileView, WorkspaceLoadingView, WorkspaceImageView, & WorkspacePDFView to DocC Documentation

  plbstl

  committed
  2fbc351

  Copy full SHA for 2fbc351

• update docs in WorkspaceAnyFileView, WorkspaceLoadingView, WorkspaceImageView, & WorkspacePDFView

  plbstl

  committed
  afc0a82

  Copy full SHA for afc0a82

• rename CodeFileDocument.typeOfFile to CodeFileDocument.utType

  plbstl

  committed
  ccc79b3

  Copy full SHA for ccc79b3

• fix: allow GIF previews to play, and with their proper dimensions

  plbstl

  committed
  6561d25

  Copy full SHA for 6561d25

• do not return

  Show description for 12aa788
  plbstl

  committed
  12aa788

  Copy full SHA for 12aa788

• update docs for CodeFileDocument.utType

  plbstl

  committed
  f039914

  Copy full SHA for f039914

• change conformance from movie to audiovisualContent in CodeFileDocument.utType

  plbstl

  committed
  b660ac7

  Copy full SHA for b660ac7

Commits on May 10, 2024

• properly display CodeFileView contents by undo-ing the padding in its parent view

  plbstl

  committed
  d0c2671

  Copy full SHA for d0c2671

• remove text, image, PDF, video restrictions on CodeFileDocument.utType

  plbstl

  committed
  1b8c8b3

  Copy full SHA for 1b8c8b3

• update docs in WorkspaceImageView

  plbstl

  committed
  2ac22a7

  Copy full SHA for 2ac22a7

• WorkspaceCodeFileView: group non-text files, so they inherit modifiers from the parent Group view

  plbstl

  committed
  c3d31a6

  Copy full SHA for c3d31a6

• WorkspaceCodeFileView: add important note on document.utType

  plbstl

  committed
  12e0ba1

  Copy full SHA for 12e0ba1

• remove SwiftUI VideoPlayer view for now, it creates a bug that I can't work around

  Show description for 8f04013
  plbstl

  committed
  8f04013

  Copy full SHA for 8f04013

• add NonTextFileView to clean up code

  Show description for acb8a63
  plbstl

  committed
  acb8a63

  Copy full SHA for acb8a63

• remove QLPreviewItem subclass from CodeFileDocument

  plbstl

  committed
  9688746

  Copy full SHA for 9688746

• rename WorkspaceCodeFileView to EditorAreaFileView

  plbstl

  committed
  425f806

  Copy full SHA for 425f806

• rename EditorView to EditorAreaView

  Show description for 151e345
  plbstl

  committed
  151e345

  Copy full SHA for 151e345

• rename 4 Workspace view files

  Show description for fe1f7bb
  plbstl

  committed
  fe1f7bb

  Copy full SHA for fe1f7bb

• move views for opening files to CodeEdit/Features/Editor

  plbstl

  committed
  cb88ec2

  Copy full SHA for cb88ec2

• move CodeFileDocument to CodeEdit/Features/Documents

  plbstl

  committed
  096bb68

  Copy full SHA for 096bb68

• NSTableViewWrapper: minor change in comment

  plbstl

  committed
  cf17bc7

  Copy full SHA for cf17bc7

• move WindowCodeFileView to CodeEdit/Features/Editor/Views

  plbstl

  committed
  950d7ed

  Copy full SHA for 950d7ed

• use AnyFileView to view all images

  Show description for b373bb6
  plbstl

  committed
  b373bb6

  Copy full SHA for b373bb6