Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CommandPalleteView and CommandPalleteViewModel classes #1655

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

dklaver15
Copy link
Contributor

Description

The CommandPalleteView class was renamed to QuickActionsView and the CommandPalleteViewModel class was renamed to QuickActionsViewModel. This was done to keep naming conventions consistent with Xcode.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few things you missed. Make sure to rename files and file comment headers.

CodeEdit/Features/Commands/Views/QuickActionsView.swift Outdated Show resolved Hide resolved
@austincondiff austincondiff self-requested a review March 30, 2024 22:20
@austincondiff austincondiff merged commit 05a40da into CodeEditApp:main Mar 31, 2024
2 checks passed
FastestMolasses pushed a commit to Angelk90/CodeEdit that referenced this pull request Apr 11, 2024
…itApp#1655)

* Renamed the CommandPalleteView class to QuickActionsView to stay consistent with Xcode naming conventions

* Renamed the CommandPalleteViewModel class to QuickActionsViewModel to stay consistent with Xcode naming conventions

* Changed name of CommandPalette class to QuickActions in comment header

Co-authored-by: Austin Condiff <[email protected]>

---------

Co-authored-by: Austin Condiff <[email protected]>
@thecoolwinter thecoolwinter added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Rename Commands overlay to Quick Actions
5 participants