Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Async Malloc Crash #1421

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix Async Malloc Crash #1421

merged 1 commit into from
Sep 12, 2023

Conversation

thecoolwinter
Copy link
Collaborator

Description

Fixes a rare bug that can happen when URL.appcast is updated from an async context. This PR moves the variable to a class property instead of a static variable, and moves some code into the main actor to prevent similar bugs.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

bombardier200
bombardier200 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austincondiff austincondiff merged commit 907cb9e into CodeEditApp:main Sep 12, 2023
@thecoolwinter thecoolwinter deleted the fix/malloc-error branch September 12, 2023 17:05
@thecoolwinter thecoolwinter added the bug Something isn't working label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombardier200 bombardier200 bombardier200 approved these changes

@matthijseikelenboom matthijseikelenboom matthijseikelenboom approved these changes

@austincondiff austincondiff austincondiff approved these changes

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecoolwinter @austincondiff @matthijseikelenboom @bombardier200