-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Rename tabgroup to editor and more #1418
[chore] Rename tabgroup to editor and more #1418
Conversation
…is opened from the project navigator or open quickly overlay, and when a different editor is selected in a split layout.
…pector sidebar to inspector area, debug area to utility area, and tab bar item to tab bar tab.
… renamed it to EditorLayoutView. Renamed WorkspaceEditorView to EditorView.
Maybe use EditorTab instead of TabBarTab. It might be literally what it is, but doesn't read nice and it's not a good name imo. Just naming it Tab is too ambiguous, because we have tabs at multiple places. Technically those are also TabBars, in the inspector for example. EditorTab indicates that is a Tab of the Editor. If anyone else has another suggestion, of course please do |
@matthijseikelenboom should we call it the EditorTabBar, EditorTab, and EditorPathBar then? |
…torTabBar, PathBar to EditorPathBar. Organized files throughout project.
@austincondiff Yeah I think that would be a good idea |
@matthijseikelenboom i did that and more in this commit. One thing I also did was move TabBar and PathBar into Editor and prefix both with Editor. |
It does not compile on my machine. If I remove that line, it fails on: CodeEdit/CodeEdit/WindowSplitView.swift Lines 48 to 62 in 8cac820
it seems to be renamed to |
@0xWDG good catch! I am not yet on Sonoma so that would explain why it is compiling on my machine just fine. Try again. Lmk if it works. |
Don't know if Sonoma has anything to do with it. Could also be your build cache |
This issue can be fixed by resetting Swift package caches. |
Description
Xcode calls each split within a split editor layout an "editor". We currently call it a "tab group". This PR renames this to be consistent.
Renames the following:
The "Editor" (previously "TabGroup") folder has been moved out of the "TabBar" (previously to "Tabs") folder
Checklist