Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SwiftUI Runtime Errors #1367

Merged

Conversation

thecoolwinter
Copy link
Collaborator

Description

Quick fix for some runtime errors that have popped up due to recent PRs. One has to do with updating terminal titles, and the other with observing and publishing an initial value. See comments for more details.

Related Issues

N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Not UI related.

Copy link
Contributor

@bombardier200 bombardier200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@matthijseikelenboom matthijseikelenboom merged commit d5a44c7 into CodeEditApp:main Jul 4, 2023
@thecoolwinter thecoolwinter deleted the fix/publishing-changes branch July 4, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants