Fix Situationally Unusable Tab Groups

[thecoolwinter]

Description

Fixes a bug where if the user has only a temporary tab open in a group, closing that tab would cause the group to be unusable.

To reproduce:

• Open a tab (leave it temporary)
• Close the tab
• Try opening a new file
• The file will not open, the only way to regain the tab group is to close the group and open a new split.

To fix, the temporary tab had to be removed correctly in the closeTab function. Before it would cause the openTab function to take an incorrect path and assume every tab after had already been created, resulting in effectively a no-op when it tried opening another file.

Related Issues

No issue opened afaik.

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

Screen.Recording.2023-06-30.at.12.08.29.AM.mov

[austincondiff]

Looks good! Thanks for the fix!