Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MainMenu's "Welcome to CodeEdit" #106

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

pkasila
Copy link
Member

@pkasila pkasila commented Mar 19, 2022

Now "Welcome to CodeEdit" in MainMenu works. I've simply changed action's target to First Responder

@pkasila pkasila requested a review from austincondiff March 19, 2022 20:50
@austincondiff austincondiff merged commit b73c8e7 into CodeEditApp:main Mar 19, 2022
austincondiff added a commit that referenced this pull request Mar 21, 2022
* Improved overall tab style to feel more native to macOS

* Fixed lint error

* More lint error fixes

* More lint error fixes

* More liner error fixes

* Create CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Fix "Welcome to CodeEdit" Main Menu item (#106)

* Fix data format (#105)

* Allow opening of `public.item` instead of `public.source-code`

* Handle errors

* Message Preview when opening the non coding file (#102)

* Cleaned up the typography for Welcome Screen

* Added support for more code editor themes

* Revert "Added support for more code editor themes"

This reverts commit 8139217.

* Revert "Cleaned up the typography for Welcome Screen"

This reverts commit 78b748b.

* Update the error message to be more informative when trying to open files that are not code related

* Added language translations for editor error and support for the Afrikaans Language

* Fixed localization changes in Russian and Belarusian

* Updated the editor error string to be short and sweet

* Update to editor error for file types.

* Change document types priority, prioritize workspace over source code file to fix #110

* Fix multiple welcome window

* Fix version localization key (#120)

* Improved overall tab style to feel more native to macOS

* Fixed lint error

* More lint error fixes

* Replicating aesthetic and behavior of standard tabs. Removed wrapper component so that code is more straightforward.

* Update WorkspaceCodeFileView.swift

Resolved conflicts

* Fixed lint errors and animations

* Added PressActionsModifier file to project

* Added PressActionsModifier.swift

* Fixed lint error

* Fixed lint error

Co-authored-by: Luke <[email protected]>
Co-authored-by: Pavel Kasila <[email protected]>
Co-authored-by: Nanashi Li <[email protected]>
Co-authored-by: Ziyuan Zhao <[email protected]>
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024
- add SwiftLintPlugin
- adjust CI workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants