Resolve #1029: Support files and folders to be dragged in externally …

[RayZhao1998]

Description

Resolve #1029

• Support files and folders to be dragged in externally into project navigator.
• Support holding option while dropping to copy.

Related Issue

• ✨ Support files and folders to be dragged in externally into project navigator #1029

Checklist

• I read and understood the contributing guide as well as the code of conduct
• My changes generate no new warnings
• My code builds and runs on my machine
• I documented my code
• Review requested

Screenshots

2023-02-05.22.45.08.mov

[matthijseikelenboom]

Does the option + drop also works from Finder to CodeEdit? In the video I only saw it happening within CodeEdit.

[thecoolwinter]

I'm getting the following error for some folders:

*** Canceling drag because exception 'NSInternalInconsistencyException' (reason 'readFromFileWrapper:ofType:error: must be overridden by class CodeFileDocument for your application to handle file packages.') was raised during a dragging session

[RayZhao1998]

I'm getting the following error for some folders:

*** Canceling drag because exception 'NSInternalInconsistencyException' (reason 'readFromFileWrapper:ofType:error: must be overridden by class CodeFileDocument for your application to handle file packages.') was raised during a dragging session

Do you have any more information such as crash stack?

[RayZhao1998]

Does the option + drop also works from Finder to CodeEdit? In the video I only saw it happening within CodeEdit.

Yes, it works. But as mentioned here, I need to try to show + when dragging with option clicked.

[austincondiff]

@RayZhao1998 From your video, I am not sure when you are holding ⌥. When holding ⌥, the cursor should change to the copy cursor as shown below to indicate the file will be copied.

(Also see this for reference).

Edit: I see from your comment above that you are aware of this.

[austincondiff]

When dragging from external sources, I notice that the file animates back to it's source on drop (even though the source disappears). This is not expected behavior, even when copying. Try dragging between two Finder windows to see for yourself.

[thecoolwinter]

I'm getting the following error for some folders:

*** Canceling drag because exception 'NSInternalInconsistencyException' (reason 'readFromFileWrapper:ofType:error: must be overridden by class CodeFileDocument for your application to handle file packages.') was raised during a dragging session

Do you have any more information such as crash stack?

It wasn't crashing entirely just throwing this error (wasn't even cancelling the drag), I can't reproduce it anymore either which is weird. Actually though, the documentation says this should have a default implementation and it doesn't even look like we're using the NSFileWrapper API. Since it's not crashing and still functional I'm okay ignoring this for now.

[austincondiff]

Looks great, see previous comments. After that we can merge.

[RayZhao1998]

Updated.

default.mov

Fixed

[austincondiff]

Thanks for making those changes, nice work!