Enhanced PWA #188
Merged
Enhanced PWA #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced multiple icon files in WEBP format with various sizes (192x192, 196x196, 228x228, 256x256, 384x384, 512x512). - Added new screenshot files in AVIF format for the web app manifest, including hero and prepare screenshots in both standard and wide formats. - Updated the manifest.ts file to include the new icons and screenshots, adjusting background and theme colors.
Synced my codebase
Collaborator
|
Delete package-lock, we are using pnpm |
Comment on lines
-11
to
-12
| background_color: "#ffffff", | ||
| theme_color: "#000000", |
Collaborator
There was a problem hiding this comment.
what if a user uses and prefers light mode? In that case, doesn't #ffffff make more sense?
Member
Author
There was a problem hiding this comment.
The background color by default is dark right...
Additionally, by matching with the app's icons's background color, during loading the icon doesnt stick out
abhitrueprogrammer
approved these changes
Apr 18, 2025
Collaborator
|
LGTM |
Closed
Member
|
well done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
manifest.tsfile to enhance the web application's manifest configuration. Key changes include the addition of a newExtendedScreenshotinterface, updates to theme and background colors, expanded metadata categories, new shortcut definitions, and a more comprehensive set of icons and screenshots.Manifest Enhancements:
Added
ExtendedScreenshotInterface: Introduced a new interface to support additional metadata for screenshots, such asform_factor. (src/app/manifest.ts, src/app/manifest.tsR3-R9)Updated Theme and Background Colors: Changed
background_colorandtheme_colorfrom#ffffffand#000000to#070114for a unified dark theme. (src/app/manifest.ts, src/app/manifest.tsL11-R83)Expanded Metadata:
categoriesfield with values such as "education" and "technology".shortcutsfor quick access to features like "Upload", including associated icons. (src/app/manifest.ts, src/app/manifest.tsL11-R83)Enhanced Icons: Replaced existing icons with a broader set of
webpicons in various sizes, includingmaskableoptions for better adaptability. (src/app/manifest.ts, src/app/manifest.tsL11-R83)Improved Screenshots: Updated screenshots to use
avifformat, added wide-format screenshots, and incorporated theform_factorproperty for better device-specific rendering. (src/app/manifest.ts, src/app/manifest.tsL11-R83)