Skip to content

Per directory configs - preliminary changes#5

Open
art049 wants to merge 3 commits into
mainfrom
per_directory_configs_preliminary
Open

Per directory configs - preliminary changes#5
art049 wants to merge 3 commits into
mainfrom
per_directory_configs_preliminary

Conversation

@art049
Copy link
Copy Markdown
Member

@art049 art049 commented Apr 17, 2024

This pull request was created automatically by CodSpeed to track performance changes of the pull request number 9550 from pylint-dev/pylint.

The original branch is fork-9550-0nf/per_directory_configs_preliminary

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 17, 2024

CodSpeed Performance Report

Merging #5 will degrade performances by 24.32%

Comparing per_directory_configs_preliminary (9b3576f) with main (bdf5a2c)

Summary

❌ 2 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main per_directory_configs_preliminary Change
test_baseline_benchmark_j1 5.9 ms 7.8 ms -24.32%
test_baseline_benchmark_j1_single_working_checker 9.5 ms 11.6 ms -18.19%

Aleksey Petryankin added 2 commits April 19, 2024 13:48
- Add opportunity to open checkers per-file, so they can use values from local config during opening
- Save command line arguments to apply them on top of each new config
- More accurate verbose messages about config files
- Enable finding config files in arbitrary directories
- Add opportunity to call linter._astroid_module_checker per file in single-process mode
- Collect stats from several calls of linter._astroid_module_checker in single-process mode
- Extend linter._get_namespace_for_file to return the path from which namespace was created
@art049 art049 force-pushed the per_directory_configs_preliminary branch from 42bbb5a to 2f6c087 Compare April 19, 2024 11:58
- Responses to review comments
- Add test for calling _astroid_module_checker on different levels
- Move Path.resolve() out of _get_namespace_for_file recursive calls
@art049 art049 force-pushed the per_directory_configs_preliminary branch from 2f6c087 to 9b3576f Compare April 20, 2024 08:29
@art049 art049 force-pushed the main branch 8 times, most recently from 0a03f65 to 87ca9a1 Compare May 2, 2024 16:05
@art049 art049 force-pushed the main branch 9 times, most recently from e8cd950 to 644e3c7 Compare May 7, 2024 13:40
@art049 art049 force-pushed the main branch 5 times, most recently from 4c7a546 to b02f3b2 Compare May 13, 2024 15:00
@art049 art049 force-pushed the main branch 4 times, most recently from 65252ee to ddfb2a4 Compare May 20, 2024 14:00
@art049 art049 force-pushed the main branch 16 times, most recently from a2f5460 to c897c2d Compare June 9, 2024 21:45
@art049 art049 force-pushed the main branch 4 times, most recently from dc4b5dd to ba1f0c7 Compare June 17, 2024 13:25
@art049 art049 force-pushed the main branch 4 times, most recently from 57fb37f to 8656186 Compare June 25, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant