Adds a new command for renaming yourself on trunk #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Apr 28, 2017
| @@ -18,6 +18,7 @@ class Trunk < Command | |||
| require 'pod/command/trunk/deprecate' | |||
| require 'pod/command/trunk/info' | |||
| require 'pod/command/trunk/me' | |||
| require 'pod/command/trunk/me_rename' | |||
| class Trunk | ||
| # @CocoaPods 1.2.1+ | ||
| # | ||
| class Rename < Me |
| def run | ||
| email = netrc['trunk.cocoapods.org'] && netrc['trunk.cocoapods.org'].login | ||
| body = { 'name' => @name, 'email' => email }.to_json | ||
| json(request_path(:post, 'sessions', body, auth_headers)) |
There was a problem hiding this comment.
what will this output on success?
|
Will it be confusing that the result of this |
segiddins
reviewed
Apr 28, 2017
| describe Command::Trunk::Register do | ||
| describe 'CLAide' do | ||
| it 'registers it self' do | ||
| Command.parse(%w[trunk me rename]).should.be.instance_of Command::Trunk::Rename |
There was a problem hiding this comment.
use %() to delimited the arrays
|
Him, yep, that is indeed totally illogical
Sigh, it will indeed need a new server route |
|
Is any workaround to rename trunk name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes CocoaPods/trunk.cocoapods.org#155
Overall the idea of re-registering with a new name to overwrite doesn't really make sense. As discussed in CocoaPods/trunk.cocoapods.org#155 I paired with @ashfurrow on adding a new command that allows you to just rename yourself.
Also, thanks @paynerc