Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm whitespace in docker-compose.yml #10

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Fodesu
Copy link
Contributor

@Fodesu Fodesu commented Aug 27, 2023

docker-compose error when whitespace exist
may be new version docker-compose limit the whitespace

@CocaineCong
Copy link
Owner

Can you provide the information of coding environment(including os,docker/compose version) you are in? because it works on my machine with whitespace 🤣
here is mine:

  • os: macos 2021/14/m1pro/mbp
  • docker: Docker version 20.10.17
  • compose: Docker Compose version 2.20.3

@Fodesu
Copy link
Contributor Author

Fodesu commented Aug 28, 2023

Can you provide the information of coding environment(including os,docker/compose version) you are in? because it works on my machine with whitespace 🤣 here is mine:

* os: macos 2021/14/m1pro/mbp

* docker: Docker version 20.10.17

* compose: Docker Compose version 2.20.3

my env is here

  • os : Fedora Linux 38 (KDE Plasma) x86_64. kernel: 6.4.6-200.fc38.x86_64
  • docker : client version - 20.10.23, server version - 20.10.23
  • docker-compose : version 1.29.2

图片
图片

@CocaineCong
Copy link
Owner

Can you provide the information of coding environment(including os,docker/compose version) you are in? because it works on my machine with whitespace 🤣 here is mine:

* os: macos 2021/14/m1pro/mbp

* docker: Docker version 20.10.17

* compose: Docker Compose version 2.20.3

my env is here

  • os : Fedora Linux 38 (KDE Plasma) x86_64. kernel: 6.4.6-200.fc38.x86_64
  • docker : client version - 20.10.23, server version - 20.10.23
  • docker-compose : version 1.29.2

图片 图片

fine, i think it is a nice choice to compatible with the older compose version, so LGTM!! 😺
by the way, i think you can update your compose, the version 1.29 was released on may 10 in 2021 🙈

@CocaineCong CocaineCong merged commit 93b4971 into CocaineCong:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants