Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env variables #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomciopp
Copy link

@tomciopp tomciopp commented Jan 9, 2020

@brweber2 This PR handles a bunch of changes, bringing the codebase up to speed. Let me know if you have any questions or concerns.

@brweber2
Copy link
Member

brweber2 commented Jan 9, 2020

At first glance this PR looks good. I will try to find some time to test it out and merge in the next few days. Thanks!

@tomciopp
Copy link
Author

tomciopp commented Jan 9, 2020

I'll probably add another commit to allow people to configure which environments we are sending error messages to raygun after this gets merged.

Note this PR removes the report_exception function on the Raygun module due to the warning that elixir emits regarding __STACKTRACE__. People will need to update their code to call report_stacktrace passing in the __STACKTRACE__ directly as is directed. Therefore we should require a bump to the minor version of the library at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants