Basic villager trades #1819
Open
Basic villager trades #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
reviewed
Apr 2, 2021
|
|
||
| public class EntityVillager extends EntityCreature implements EntityNPC, EntityAgeable { | ||
| public class EntityVillager extends EntityCreature implements InventoryHolder, EntityNPC, EntityAgeable { |
There was a problem hiding this comment.
Not sure about implementing InventoryHolder here, since it has no physical inventory
There was a problem hiding this comment.
Villager trading is inventory and since villager contains trade recipes, i find them as inventory holders.
Alemiz112
reviewed
Apr 4, 2021
IrineuMC
approved these changes
Apr 6, 2021
Fix nbt Handle trade inventory transaction
lt-name
suggested changes
May 2, 2021
| } | ||
|
|
||
| @Override | ||
| public boolean onInteract(Player player, Item item) { |
There was a problem hiding this comment.
(Google Translate)
I think we also need to rewrite the onInteract(Player player, Item item, Vector3 clickedPos) method
like this:
@Override
public boolean onInteract(Player player, Item item, Vector3 clickedPos) {
if (super.onInteract(player, item, clickedPos)) {
return true;
}
return this.onInteract(player, item);
}
sticknycu
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should add basic villager trade inventory with custom api.