docs(decisions): ADR-0053 archive 记忆层仓与旧 ADR 归档迁移(W1-C1 .github#164) - #72
Conversation
|
Warning Review limit reached
Next review available in: 9 minutes Limit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
PR Summary by Qododocs(decisions): Add ADR-0053 for archive repo + ADR migration plan
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
There was a problem hiding this comment.
Pull request overview
Adds ADR-0053 to document the W1-C1 decision and process for migrating historical ADR originals into a dedicated archive repository while keeping agent-registry/decisions/ as an index/tombstone layer (supporting the governance and future gate changes described in .github#164).
Changes:
- Add
decisions/ADR-0053-archive-repo-and-adr-migration.mddefining the archive repo, byte-faithful migration approach, anddecisions/INDEX.yamltombstone index design. - Document expected gate/drift-check behavior for “index world vs legacy world” compatibility during rollout.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - status: accepted(2026-08-21) | ||
| - deciders: 人(owner randypanding)+ AI | ||
| - 关联: .github#164(W1-C1 工作卡)、宪法 specs/IR-0003/constitution.md §1(记忆层/拆家原则)、§13 推论二(数据飞轮)、.github#96(ADR 实质校验——索引格式为其预留扩展点) |
Code Review by Qodo
1. INDEX path inconsistent
|
| 3. **墓碑索引 = `agent-registry/decisions/INDEX.yaml`**(机器可读,随 ADR 同仓 | ||
| 同 PR 治理):`version/source_commit/migrated_at/entries[]`,每 entry 含 | ||
| number/title/file/lifecycle/decision_status/archive_path/content_sha256, |
There was a problem hiding this comment.
1. Index path inconsistent 🐞 Bug ≡ Correctness
ADR-0053 names the tombstone index as agent-registry/decisions/INDEX.yaml but later refers to fetching decisions/INDEX.yaml, creating an ambiguous single source of truth for implementers and gate authors. This inconsistency can cause follow-up scripts/workflows to read/write the wrong location and break the intended “index world” behavior.
Agent Prompt
### Issue description
ADR-0053 uses two different path forms for the same INDEX.yaml file (`agent-registry/decisions/INDEX.yaml` vs `decisions/INDEX.yaml`). This makes the ADR ambiguous and increases the risk that downstream implementation PRs build against the wrong path.
### Issue Context
This ADR is intended to be the decision backbone for the migration and gate changes. It should name a single canonical location for the index (and if cross-repo, specify it consistently).
### Fix Focus Areas
- decisions/ADR-0053-archive-repo-and-adr-migration.md[32-56]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
|
||
| - status: accepted(2026-08-21) | ||
| - deciders: 人(owner randypanding)+ AI | ||
| - 关联: .github#164(W1-C1 工作卡)、宪法 specs/IR-0003/constitution.md §1(记忆层/拆家原则)、§13 推论二(数据飞轮)、.github#96(ADR 实质校验——索引格式为其预留扩展点) |
There was a problem hiding this comment.
2. Constitution path likely wrong 🐞 Bug ⚙ Maintainability
ADR-0053 references a constitution document at specs/IR-0003/constitution.md, but existing ADRs in this repo refer to the constitution as specs/constitution.md. This mismatch makes the reference hard to resolve and is likely to send readers to a non-canonical (or nonexistent) path.
Agent Prompt
### Issue description
ADR-0053 cites the constitution using a path format that conflicts with other ADRs, which makes it unclear what the authoritative location is.
### Issue Context
Earlier accepted ADRs in this repository already established a path reference style for the constitution.
### Fix Focus Areas
- decisions/ADR-0053-archive-repo-and-adr-migration.md[5-5]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
动机
宪法 §1 记忆层/拆家原则(旧 ADR 不删除,标 active/superseded/archived 迁记忆层)+ §13 推论二(archive=数据飞轮战略资产)。W1-C1(.github#164)的决策背书 ADR。
变更清单
decisions/ADR-0053-archive-repo-and-adr-migration.md(单文件,无其他变更)AC 映射(.github#164)
设计要点
测试方法
风险与回滚