Skip to content
This repository was archived by the owner on Aug 24, 2026. It is now read-only.

docs: ADR-0016 附录勘误——豁免对象定性修正为破玻璃误直推(ADR-0017) - #25

Merged
randypanding merged 1 commit into
mainfrom
adr0016-appendix-errata
Aug 19, 2026
Merged

docs: ADR-0016 附录勘误——豁免对象定性修正为破玻璃误直推(ADR-0017)#25
randypanding merged 1 commit into
mainfrom
adr0016-appendix-errata

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

改了什么

  • decisions/ADR-0016-redteam-remediation-batch2.md 附录:
    • 标题「初始建仓导入直推豁免」→「破玻璃直推豁免机制」
    • 初版"初始建仓导入"定性加删除线并指向勘误段
    • 边界条款改为"豁免对象仅为已经 ADR 追认回填的个案破玻璃直推"
    • 新增「勘误(2026-08-19,ADR-0017 落地后)」段:diff 证据 + 定性修正 + 语义收窄说明

为什么

附录初版(AR#24)把 9b056b3a/416f5f5 定性为"初始建仓导入(彼时仓库尚不存在,结构上无法走 PR)"。经 compare API diff 复核不成立:.github 仓 08-18 即存在、PR 流程全程运转(#1-#19 已合并,直推父提交就是 #19 合并提交),净变更仅为 Trae IDE 分享 zip + 误入 gitlink——无任何治理树内容。ADR-0017(AR#23)已按破玻璃误直推完成 ADR-0006 三件套回填,事件定性以其为准。

勘误的治理意义:"初始建仓导入"会被读作结构性豁免先例——未来任何建仓直推都可援引本附录要求豁免;修正后豁免语义收窄为"个案经 ADR 追认",不可泛化援引。豁免机制(逐完整 SHA + ADR 背书)与已登记条目不变。配套:.github PR #60(expected-state.json 注释 + drift-check §8 输出口径同步修正)。

怎么验证

  • diff 证据独立复核(f3974a6...9b056b3a / 9b056b3a...416f5f5 compare API),与 ADR-0017 记录一致
  • ADR 结构仍满足 drift-check §10 实体性校验(H1 编号/status/背景/决策+正文未动,仅附录内部修正)
  • 纯文档勘误,validate/pytest 无涉

风险 / 回滚

  • 无:决策记录的诚实性修正,机制与条目零变更

ADR: ADR-0017(事件定性);ADR: ADR-0016(附录勘误本体)

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@randypanding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Limit details: You’ve used all 3 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c6567d99-3ee0-447e-8e17-8e0633cf0f4a

📥 Commits

Reviewing files that changed from the base of the PR and between 793d80d and 9c498f0.

📒 Files selected for processing (1)
  • decisions/ADR-0016-redteam-remediation-batch2.md

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Correct ADR-0016 break-glass direct-push exemption rationale

📝 Documentation 🐞 Bug fix 🕐 10-20 Minutes

Grey Divider

AI Description

• Corrects two direct pushes previously misclassified as repository bootstrap activity.
• Adds compare evidence and aligns the incident classification with ADR-0017.
• Restricts exemptions to SHA-specific break-glass cases retrospectively approved by ADR.
Diagram

graph TD
  E["Compare Evidence"] --> R["ADR-0017 Record"] --> C["ADR-0016 Erratum"] --> B["Narrowed Boundary"] --> M["SHA Mechanism"]
Loading
High-Level Assessment

Directly correcting ADR-0016 is the appropriate approach because it removes the misleading precedent at its source while retaining the established SHA-specific exemption mechanism. Updating ADR-0017 alone would leave contradictory guidance in ADR-0016.

Files changed (1) +13 / -3

Other (1) +13 / -3
ADR-0016-redteam-remediation-batch2.mdCorrect the direct-push exemption classification and boundary +13/-3

Correct the direct-push exemption classification and boundary

• Renames the appendix around break-glass direct-push exemptions and strikes the unsupported repository-bootstrap characterization. Adds compare evidence, defers incident classification to ADR-0017, and limits exemptions to exact-SHA cases retrospectively approved through an ADR without changing existing entries or enforcement.

decisions/ADR-0016-redteam-remediation-batch2.md

@randypanding
randypanding merged commit 421eefb into main Aug 19, 2026
7 checks passed
@randypanding
randypanding deleted the adr0016-appendix-errata branch August 19, 2026 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant