governance: 登记 agent-registry 破玻璃直推豁免(ADR-0030) - #99
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough变更概述新增 Changes直推豁免配置
Suggested labels: Merge Risk: ⚪ Minimal · up to This change registers two approved direct-push exemptions in the governance state; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoRegister agent-registry direct-push exemptions (ADR-0030)
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. 豁免审计归因错误
|
| "agent-registry": [ | ||
| "60bd1557481fa89d0358302e150a8f7d9381309c", | ||
| "e9424d220ded331c221b37135faa9d6e9cd1ecac" |
There was a problem hiding this comment.
1. 豁免审计归因错误 🐞 Bug ◔ Observability
新增的两条 agent-registry 豁免由 ADR-0030 背书,但 drift-check.sh 对匹配项固定输出“ADR-0017”,导致每次检查都生成错误的治理审计依据。该错误会误导事件追溯和后续豁免复核。
Agent Prompt
## Issue description
`direct_push_exemptions` 新增了由 ADR-0030 背书的提交,但检查结果仍将所有豁免固定归因于 ADR-0017。
## Issue Context
豁免数据目前只保存 SHA,消费者无法确定每条记录的实际 ADR。请为豁免保留可审计的 ADR 归属,并让成功日志输出对应依据;至少不要继续输出错误的固定 ADR 编号。
## Fix Focus Areas
- governance/expected-state.json[50-80]
- governance/drift-check.sh[217-228]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
摘要
把 agent-registry 两条破玻璃直推登记入
direct_push_exemptions(ADR-0030 背书,agent-registry#44 已合并):60bd155(owner 直推,误入 agent-platform gitlink → 全仓 PR CI 死锁)e9424d2(admin 破玻璃移除该 gitlink 解死锁)同型先例:.github 仓 ae905a6 + ADR-0017 附录。
验证
Summary by CodeRabbit
agent-registry仓库新增直接推送豁免配置。