Skip to content

ADR-0024: Use-up-Plan 申报入图 + bootstrap 直推豁免登记(ADR-0024) - #77

Merged
randypanding merged 1 commit into
mainfrom
adr-0024-use-up-plan-registry
Aug 19, 2026
Merged

ADR-0024: Use-up-Plan 申报入图 + bootstrap 直推豁免登记(ADR-0024)#77
randypanding merged 1 commit into
mainfrom
adr-0024-use-up-plan-registry

Conversation

@randypanding

@randypanding randypanding commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

改了什么(C1,ADR-0024 背书,agent-registry PR #36 已合)

  • REPOS.yaml:增 Use-up-Plan(L2 / public / active)——AI 多 plan 额度管理与路由调度工具
  • expected-state.json:direct_push_exemptions 增 Use-up-Plan 两个完整 SHA(Initial commit ba75401f… + GitHub UI 编辑 82132afc…,ADR-0021 (b) 建仓 bootstrap 类)

为什么

drift-check 3 项漂移(§7b 未申报 + §8 两直推)。建仓时序上不可能走 PR,按 ADR-0021 已裁定模式登记;平台配套已补全(wiki/projects 关、production env RL-1、App 挂载 AG-4、基线 apply 已覆盖)。

怎么验证

gate 全绿(含 adr-required 存在性);合并后 drift-check 对 Use-up-Plan 全 OK、组织漂移清零。

风险 / 回滚

无新增豁免通道;回滚=新 ADR。

Summary by CodeRabbit

  • 治理
    • 新增并登记 Use-up-Plan 仓库,标记为 L2、公开且处于活跃状态。
    • 补充该仓库的职责与治理信息。
    • 更新直接推送豁免记录,纳入两个指定提交。

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 63b81c51-ff6d-421d-b6bd-4dea1c82936d

📥 Commits

Reviewing files that changed from the base of the PR and between fb19424 and 010702b.

📒 Files selected for processing (2)
  • governance/REPOS.yaml
  • governance/expected-state.json

Included review availability: Your plan provides up to 3 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

新增 Use-up-Plan 的治理注册信息,并登记两个直推豁免 commit SHA。

Changes

Use-up-Plan 治理配置

Layer / File(s) Summary
仓库注册与直推豁免
governance/REPOS.yaml, governance/expected-state.json
新增 Use-up-Plan 的 L2、公开、活跃属性及职责说明,并登记两个直推豁免 commit SHA。

Possibly related PRs

Suggested labels: tech-debt

Merge Risk: ⚪ Minimal · up to 01070

This PR adds the declared repository entry and bootstrap exemption records; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning 标题未使用要求的 Conventional Commits 前缀,且长度为 55 个字符,超过 50 个字符限制。 将标题改为以 feat、fix、chore、refactor、docs 或 test 开头,并压缩至不超过 50 个字符。
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adr-0024-use-up-plan-registry

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Register Use-up-Plan and Bootstrap Push Exemptions

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Registers Use-up-Plan as an active public L2 product repository.
• Exempts two ADR-approved bootstrap commits from direct-push drift detection.
• Aligns declared governance state with the existing GitHub organization state.
Diagram

graph TD
  A["REPOS.yaml"] -->|declares repository| C["Drift Check"] -->|queries| D[("GitHub Org")] -->|contains| E["Use-up-Plan"]
  B["Expected State"] -->|exempts SHAs| C
  C -->|validates| E
Loading
High-Level Assessment

The PR follows the existing governance model: register the repository in the canonical map and enumerate only ADR-approved bootstrap commits by full SHA. Dynamic or repository-wide exemptions were considered but would weaken the per-commit audit boundary and allow future direct pushes to bypass drift detection.

Files changed (2) +12 / -0

Other (2) +12 / -0
REPOS.yamlRegister Use-up-Plan in the repository map +8/-0

Register Use-up-Plan in the repository map

• Adds Use-up-Plan as an active, public L2 product repository. Documents its AI plan quota management, allocation, and routing purpose, along with its ADR-0024 bootstrap status.

governance/REPOS.yaml

expected-state.jsonRecord Use-up-Plan bootstrap push exemptions +4/-0

Record Use-up-Plan bootstrap push exemptions

• Adds the initial and GitHub UI bootstrap commit SHAs to the direct-push exemption registry. This prevents ADR-approved repository creation commits from being reported as governance drift without creating a blanket exemption.

governance/expected-state.json

@randypanding
randypanding merged commit 5886702 into main Aug 19, 2026
7 of 8 checks passed
@randypanding
randypanding deleted the adr-0024-use-up-plan-registry branch August 19, 2026 10:54
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Bootstrap exemptions misclassified 🐞 Bug ◔ Observability
Description
The new Use-up-Plan bootstrap commits are always logged as break-glass backfills attributed to
ADR-0017, despite this PR declaring them as ADR-0024 bootstrap exemptions. This produces misleading
governance audit output whenever drift-check processes either commit.
Code

governance/expected-state.json[R66-68]

+    "Use-up-Plan": [
+      "ba75401f84eb915a119568c246168d8cdb8a1200",
+      "82132afc169a54b98869df136d1d6235124c4a96"
Relevance

●●● Strong

Bootstrap and break-glass exemptions were explicitly separated; audit output should preserve that
distinction.

PR-#75
PR-#60

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The expected-state documentation distinguishes ADR-0017 break-glass backfills from ADR-0021-style
bootstrap exemptions, while REPOS.yaml classifies Use-up-Plan specifically as an ADR-0024 bootstrap
case. Nevertheless, the detector emits the fixed text “已回填破玻璃直推(§8 豁免清单,ADR-0017)” for every SHA
found in this newly extended map.

governance/expected-state.json[50-68]
governance/REPOS.yaml[73-79]
governance/drift-check.sh[217-227]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly registered Use-up-Plan commits are bootstrap exemptions backed by ADR-0024, but `drift-check.sh` reports every exemption as a break-glass backfill under ADR-0017.

## Issue Context
`direct_push_exemptions` currently stores only SHA arrays, so the detector cannot distinguish bootstrap events from break-glass remediation or report their actual ADR provenance. Either represent exemption metadata explicitly or change the output to accurate generic wording.

## Fix Focus Areas
- governance/expected-state.json[50-68]
- governance/drift-check.sh[217-227]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 7 rules
Review mode: ⚖️ Balanced: This changes governance registry and exemption state that drive compliance/drift behavior, so it merits a complete review despite being small.

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment on lines +66 to +68
"Use-up-Plan": [
"ba75401f84eb915a119568c246168d8cdb8a1200",
"82132afc169a54b98869df136d1d6235124c4a96"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Bootstrap exemptions misclassified 🐞 Bug ◔ Observability

The new Use-up-Plan bootstrap commits are always logged as break-glass backfills attributed to
ADR-0017, despite this PR declaring them as ADR-0024 bootstrap exemptions. This produces misleading
governance audit output whenever drift-check processes either commit.
Agent Prompt
## Issue description
The newly registered Use-up-Plan commits are bootstrap exemptions backed by ADR-0024, but `drift-check.sh` reports every exemption as a break-glass backfill under ADR-0017.

## Issue Context
`direct_push_exemptions` currently stores only SHA arrays, so the detector cannot distinguish bootstrap events from break-glass remediation or report their actual ADR provenance. Either represent exemption metadata explicitly or change the output to accurate generic wording.

## Fix Focus Areas
- governance/expected-state.json[50-68]
- governance/drift-check.sh[217-227]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant