Skip to content

repos: env-defs 申报入图——环境期望态定义仓 L0(W1-C2) - #428

Merged
randypanding merged 1 commit into
mainfrom
card/410-env-defs-repos
Aug 29, 2026
Merged

repos: env-defs 申报入图——环境期望态定义仓 L0(W1-C2)#428
randypanding merged 1 commit into
mainfrom
card/410-env-defs-repos

Conversation

@randypanding

@randypanding randypanding commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Card: #410

变更

  • governance/REPOS.yaml:新增 env-defs 仓申报(layer=L0、public、active、entry_protocol=true)

说明

  • env-defs = 环境期望态定义仓(三面分离声明面载体,ADR-0103 决策 5):environments/*.yaml 声明云内网 dev/staging 期望态;reports/ 为漂移快照落点(W4-R1 泛化 drift 消费)
  • 建仓:template-service 派生 + new-repo-init.sh 基线(squash-only/production environment/App 挂载)
  • 环境定义内容 PR:env: 云内网 dev/staging 环境期望态骨架(W1-C2 / IFACE-05) env-defs#1
  • 本 PR 为 C1 治理路径变更(governance/ 下),引用 ADR-0103(决策 5:环境定义独立仓 env-defs 承载期望态声明)

Summary by CodeRabbit

  • 新功能
    • 新增 env-defs 仓库登记信息。
    • 标注其为公开、活跃的 L0 层仓库,并启用入口协议。
    • 明确该仓库用于维护环境期望状态、漂移报告及相关路径。

Copilot AI lite review requested due to automatic review settings August 29, 2026 06:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Register env-defs as an active L0 governance repository

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Registers env-defs as a public, active L0 repository.
• Defines environment declarations and drift reports as governed repository paths.
• Enrolls env-defs in organization-wide entry protocol validation.
Diagram

graph TD
  A["Governance Registry"] -->|declares| B["env-defs"] -->|stores| C["Environment Specs"]; B -->|publishes| D["Drift Reports"]; A -->|enables| E["Protocol Check"]
Loading
High-Level Assessment

The centralized REPOS.yaml declaration is the established organization-map integration point and is appropriate for this change. A separate registry or executable integration would duplicate governance truth without adding value.

Files changed (1) +11 / -0

Other (1) +11 / -0
REPOS.yamlRegister env-defs in the organization repository map +11/-0

Register env-defs in the organization repository map

• Adds env-defs as a public, active L0 repository backed by ADR-0103. Declares environments/ and reports/ as key paths, documents reference-only secret handling, and enables entry protocol enforcement.

governance/REPOS.yaml

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c185925-c0a6-4455-aaf8-2d861e9c5857

📥 Commits

Reviewing files that changed from the base of the PR and between 306289b and eda5f70.

📒 Files selected for processing (1)
  • governance/REPOS.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

变更概述

governance/REPOS.yaml 中新增 env-defs 仓库注册项。配置包含治理层级、可见性、状态、职责、关键路径和入口协议。

Changes

仓库注册

Layer / File(s) Summary
env-defs 注册配置
governance/REPOS.yaml
新增 env-defs 条目,声明其为 L0 层、公开且 active,并配置环境期望态、漂移报告职责、关键路径及入口协议。

Suggested labels: feature

Merge Risk: ⚪ Minimal · up to eda5f

This change registers the existing public env-defs repository as an active entry in the environment-definition governance path. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning 标题清楚描述了 env-defs 仓库注册变更,且长度为 40 个字符。但标题未使用要求的 Conventional Commits 前缀。 将标题改为以 feat:fix:chore:refactor:docs:test: 开头,并保持不超过 50 个字符。例如:feat: 注册 env-defs 仓库
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch card/410-env-defs-repos

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the feature label Aug 29, 2026
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. L0 onboarding map stays stale 🐞 Bug ⚙ Maintainability
Description
Adding env-defs as L0 leaves the PM Playbook’s explicit “L0 governance repositories” count and
list without the new repository, so onboarding readers receive a contradictory layer map instead of
the newly declared topology. That same sentence already misclassifies archive as L0 even though
the registry declares it L1, and this change is the appropriate point to synchronize the sibling
enumeration.
Code

governance/REPOS.yaml[R182-183]

+  - name: env-defs
+    layer: L0
Relevance

●●● Strong

Recent PRs consistently synchronize governance source changes with onboarding and navigation
documentation.

PR-#389
PR-#387

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The registry defines .github and CI-Workflows as L0, archive as L1, and now env-defs as L0,
while the PM onboarding step still states there are three L0 repositories and names .github,
CI-Workflows, and archive.

governance/REPOS.yaml[20-46]
governance/REPOS.yaml[182-191]
docs/pm/PLAYBOOK.md[31-37]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new L0 `env-defs` declaration makes the PM Playbook’s hard-coded L0 repository count/list stale, while that list also incorrectly places `archive` in L0.

## Issue Context
`governance/REPOS.yaml` is the organization-map source of truth. The onboarding summary should either match it or avoid maintaining a duplicate exhaustive enumeration.

## Fix Focus Areas
- governance/REPOS.yaml[182-183]
- docs/pm/PLAYBOOK.md[31-34]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 22 rules
Review mode: ⚖️ Balanced

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread governance/REPOS.yaml
Comment on lines +182 to +183
- name: env-defs
layer: L0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. L0 onboarding map stays stale 🐞 Bug ⚙ Maintainability

Adding env-defs as L0 leaves the PM Playbook’s explicit “L0 governance repositories” count and
list without the new repository, so onboarding readers receive a contradictory layer map instead of
the newly declared topology. That same sentence already misclassifies archive as L0 even though
the registry declares it L1, and this change is the appropriate point to synchronize the sibling
enumeration.
Agent Prompt
## Issue description
The new L0 `env-defs` declaration makes the PM Playbook’s hard-coded L0 repository count/list stale, while that list also incorrectly places `archive` in L0.

## Issue Context
`governance/REPOS.yaml` is the organization-map source of truth. The onboarding summary should either match it or avoid maintaining a duplicate exhaustive enumeration.

## Fix Focus Areas
- governance/REPOS.yaml[182-183]
- docs/pm/PLAYBOOK.md[31-34]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@randypanding
randypanding merged commit ec75a0f into main Aug 29, 2026
18 checks passed
@randypanding
randypanding deleted the card/410-env-defs-repos branch August 29, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants