Skip to content

governance: ADR-0085 退役层宪法级跟修(agent_team_lifecycle 废止等五项) - #390

Merged
randypanding merged 1 commit into
mainfrom
gov-align/self-consistency
Aug 26, 2026
Merged

governance: ADR-0085 退役层宪法级跟修(agent_team_lifecycle 废止等五项)#390
randypanding merged 1 commit into
mainfrom
gov-align/self-consistency

Conversation

@randypanding

Copy link
Copy Markdown
Contributor

治理中枢自洽性跟修(ADR-0085/0095,全仓对齐批次之一):

  1. flows.agent_team_lifecycle 整体废止——四步全部引用已退役声明层语义(team 实例化/event.schema/handoff),引用的 AR-5/6/7 已不存在于 agent_runtime;改为废止注记,角色生命周期由 ADR-0095 角色路由承载
  2. governance_change 头注释移出 agent-registry;C1 scope tests/ 描述改为治理检测器元测试;rationale 执法路径全集改指 CI-Workflows ci.yml
  3. policy/contracts.yaml:ADR 家园口径 agent-registry/decisions→archive/adr;agent-registry 契约声明随退役移除(CI-Workflows policy-bundled.yaml 快照已同步,CI-Workflows#124)
  4. profile/README.md:产品仓行补齐 Viral_Radar/Media-Monitor
  5. REPOS.yaml:mutual key_paths tests/golden/→golden/(与仓内实态一致)

验证:YAML 语法三文件过;governance/tests/test-navigation.sh 35/35 pass(含 profile 退役仓不列名检查)。

说明:与在途 #388(ADR-0096)/#389(ADR-0097)改动面不重叠(本 PR 不触 expected-state.json 与 conductor.yml)。ADR-0085。

…ntracts 退役仓出册 + REPOS key_paths 勘误

- GOVERNANCE.yaml:flows.agent_team_lifecycle 整体废止(四步全部引用已退役的
  team 实例化/event.schema/handoff 语义,AR-5/6/7 已不存在——改为废止注记,
  角色生命周期由 ADR-0095 角色路由承载)
- GOVERNANCE.yaml:governance_change 头注释移出 agent-registry;C1 scope tests/
  描述改治理检测器元测试;rationale 机器执法路径全集改 CI-Workflows ci.yml
  (agent-registry validate 已退役废止)
- policy/contracts.yaml:ADR 家园注释 agent-registry/decisions→archive/adr;
  agent-registry 契约声明随退役移除
- profile/README.md:产品仓行补齐 Viral_Radar/Media-Monitor(退役仓按
  test-navigation §D 规则不在首页列名,指向 REPOS.yaml)
- REPOS.yaml:mutual key_paths tests/golden/→golden/(与仓内实态一致)

验证:YAML 三文件语法过、test-navigation 34/34 pass(含 profile 退役仓检查)
Copilot AI lite review requested due to automatic review settings August 26, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 65383ffe-69cd-489a-877c-e9d3fa1cd39b

📥 Commits

Reviewing files that changed from the base of the PR and between 30cff2f and 7bc65cc.

📒 Files selected for processing (4)
  • governance/GOVERNANCE.yaml
  • governance/REPOS.yaml
  • governance/policy/contracts.yaml
  • profile/README.md

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

ADR-0085:退役 agent 声明层并对齐治理清单

⚙️ Configuration changes 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• 废止 agent_team_lifecycle,角色生命周期统一交由 ADR-0095 路由承载。
• 移除退役 agent-registry 契约,并将 ADR 正本指向 archive。
• 校正 C1 执法口径、仓库关键路径与产品仓索引。
Diagram

graph TD
  A["Archive ADR"] --> B["Governance Model"] --> C["CI Workflows"]
  B --> D["Role Routing"]
  A --> E["Contracts Policy"] --> C
  F["Repository Catalog"] --> G["Profile Index"]
Loading
High-Level Assessment

当前做法最合适:直接删除已失效的可执行声明,并保留简短退役注记,可避免 agent-registry 继续被误认为活跃真源。保留 deprecated 配置块虽能展示历史,但会与 ADR-0095 路由和 CI 实际执法形成双重语义;历史应继续由 git 与 archive/retired 承载。

Files changed (4) +15 / -22

Documentation (1) +1 / -1
README.md补全产品仓首页索引 +1/-1

补全产品仓首页索引

• 在产品仓概览中补充 Viral_Radar 与 Media-Monitor,并明确完整状态及退役信息以 REPOS.yaml 为准。

profile/README.md

Other (3) +14 / -21
GOVERNANCE.yaml废止 agent 团队生命周期并对齐 C1 执法口径 +8/-9

废止 agent 团队生命周期并对齐 C1 执法口径

• 移除依赖已退役 team、event.schema 与 handoff 语义的 agent_team_lifecycle 四步流程,改为指向 ADR-0095 角色路由。同步从治理变更范围和说明中移除 agent-registry,并将 C1 测试及机器执法口径对齐现行治理检测器与 CI-Workflows。

governance/GOVERNANCE.yaml

REPOS.yaml校正 mutual golden fixtures 关键路径 +1/-1

校正 mutual golden fixtures 关键路径

• 将 mutual 的关键路径从不存在的 tests/golden/ 修正为仓库根目录 golden/,使治理目录与仓内实态一致。

governance/REPOS.yaml

contracts.yaml移除退役 agent-registry 契约声明 +5/-11

移除退役 agent-registry 契约声明

• 将 ADR 实体校验家园更新为 archive/adr/,并删除只读归档仓 agent-registry 的 JSON Schema 契约配置。盘点备注同步归并 ADR-0085 已退役仓。

governance/policy/contracts.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@randypanding
randypanding merged commit 390828a into main Aug 26, 2026
15 checks passed
@randypanding
randypanding deleted the gov-align/self-consistency branch August 26, 2026 17:48
randypanding added a commit that referenced this pull request Aug 26, 2026
来源 PR 复查发现物(#176..#390 全量复查):
- 误提交 .pyc 出库:scripts/__pycache__(#230 引入)、
  specs/IR-0004/suite/__pycache__(#338)、specs/ISSUE-263/suite/__pycache__(#336);
  附 .gitignore(__pycache__/、*.pyc)防复发
- governance/metrics.py:移除恒未读局部 val(#253 引入,ADR-0073 计算库)
- governance/dashboard-update.py:TemporaryDirectory with 块内 isdir 恒真检查删除
- scripts/sli-report.sh:X if False else 死分支简化 + die 后不可达 OR 链残串清理
  (#184/#197-203/#357 落位文件,ADR-0059 口径零改动)

不改动:gate/verdict/drift 语义、workflow YAML、REPOS.yaml/治理数据、pinned SHA。

验证:python -m compileall(除既有 escalate-test-issue.py 语法错,
见 issue 392 另报);bash -n 全绿;governance/tests/test-*.sh 10 套全过;
sli-report --self-test PASS=8 FAIL=0;yaml 解析 OK。

Card: #392
ADR: ADR-0059(SLI 口径保持)、ADR-0073(metrics/dashboard 纯函数契约保持)
randypanding added a commit that referenced this pull request Aug 26, 2026
adversary-gate(ADR-0067/0082)对 specs/** 任意变更(含缓存删除)
fail-closed 要求 survived 审计。本卡为技术债清扫而非 spec 套件变更,
按保守原则不触发该审计面:specs/*/suite/__pycache__/*.pyc 暂留库,
作为已申报债务记录于 issue #392 与 PR 描述。

Card: #392

refactor: 构建产物出库 + 死代码移除(行为保持;近一周 PR 技债清扫)

来源 PR 复查发现物(#176..#390 全量复查):
- 误提交 .pyc 出库:scripts/__pycache__(#230 引入)、
  specs/IR-0004/suite/__pycache__(#338)、specs/ISSUE-263/suite/__pycache__(#336);
  附 .gitignore(__pycache__/、*.pyc)防复发
- governance/metrics.py:移除恒未读局部 val(#253 引入,ADR-0073 计算库)
- governance/dashboard-update.py:TemporaryDirectory with 块内 isdir 恒真检查删除
- scripts/sli-report.sh:X if False else 死分支简化 + die 后不可达 OR 链残串清理
  (#184/#197-203/#357 落位文件,ADR-0059 口径零改动)

不改动:gate/verdict/drift 语义、workflow YAML、REPOS.yaml/治理数据、pinned SHA。

验证:python -m compileall(除既有 escalate-test-issue.py 语法错,
见 issue 392 另报);bash -n 全绿;governance/tests/test-*.sh 10 套全过;
sli-report --self-test PASS=8 FAIL=0;yaml 解析 OK。

Card: #392
ADR: ADR-0059(SLI 口径保持)、ADR-0073(metrics/dashboard 纯函数契约保持)


(注:specs/*/suite/__pycache__/*.pyc 经重估移出本 PR——adversary-gate 对 specs/** 变更类 fail-closed 要求 survived 审计;作为已申报债务留档 issue #392 与 PR 描述。)
randypanding added a commit that referenced this pull request Aug 26, 2026
adversary-gate(ADR-0067/0082)对 specs/** 任意变更(含缓存删除)
fail-closed 要求 survived 审计。本卡为技术债清扫而非 spec 套件变更,
按保守原则不触发该审计面:specs/*/suite/__pycache__/*.pyc 暂留库,
作为已申报债务记录于 issue #392 与 PR 描述。

Card: #392

refactor: 构建产物出库 + 死代码移除(行为保持;近一周 PR 技债清扫)

来源 PR 复查发现物(#176..#390 全量复查):
- 误提交 .pyc 出库:scripts/__pycache__(#230 引入)、
  specs/IR-0004/suite/__pycache__(#338)、specs/ISSUE-263/suite/__pycache__(#336);
  附 .gitignore(__pycache__/、*.pyc)防复发
- governance/metrics.py:移除恒未读局部 val(#253 引入,ADR-0073 计算库)
- governance/dashboard-update.py:TemporaryDirectory with 块内 isdir 恒真检查删除
- scripts/sli-report.sh:X if False else 死分支简化 + die 后不可达 OR 链残串清理
  (#184/#197-203/#357 落位文件,ADR-0059 口径零改动)

不改动:gate/verdict/drift 语义、workflow YAML、REPOS.yaml/治理数据、pinned SHA。

验证:python -m compileall(除既有 escalate-test-issue.py 语法错,
见 issue 392 另报);bash -n 全绿;governance/tests/test-*.sh 10 套全过;
sli-report --self-test PASS=8 FAIL=0;yaml 解析 OK。

Card: #392
ADR: ADR-0059(SLI 口径保持)、ADR-0073(metrics/dashboard 纯函数契约保持)


(注:specs/*/suite/__pycache__/*.pyc 经重估移出本 PR——adversary-gate 对 specs/** 变更类 fail-closed 要求 survived 审计;作为已申报债务留档 issue #392 与 PR 描述。)

Co-authored-by: randypanding <randypanding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants