Repository navigation
governance: 拆除 required_review_thread_resolution 死锁(P1-2,ADR-0031) #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
dcbaf07
governance: 拆除 required_review_thread_resolution 死锁(P1-2,ADR 待补)
randypanding 07cb62b
governance: AGENTS.md 索引登记 bot-channels.md(Qodo review:规范可发现性)+ 补尾换行
randypanding ee286e4
governance: bot-channels 按 CodeRabbit 修正事实描述(结论 vs annotation、reviews…
randypanding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # 自动化反馈通道规范(bot / agent) | ||
|
|
||
| 适用对象:一切以机器身份在组织仓库产出反馈的自动化——GitHub App | ||
| (cloudbrid-agent)、Actions workflow、任何未来接入的 bot / reviewer agent。 | ||
|
|
||
| ## 规则 1:机器不得创建 review comment / review thread | ||
|
|
||
| 机器意见只允许两种通道: | ||
|
|
||
| 1. **check run annotation**(首选——随 required check 状态进入合并判据) | ||
| 2. **普通 PR comment**(issue comment,不产生 review 状态) | ||
|
|
||
| 禁止机器调用 `POST /pulls/{n}/comments`(review comment)、 | ||
| `POST /pulls/{n}/reviews`(含 COMMENT 结论的 review)——这两类操作产生 | ||
| review thread。 | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
| 理由(自动合并计划 #81 §2.2 / P1-2 #83):`required_review_thread_resolution` | ||
| 曾经为 true 时,任何 bot 留下的 unresolved thread 都是无人值守下的永久 | ||
| pending 死锁——没有人去点 resolve。该 required 条件已在 P1-2 移除;本规范 | ||
| 保证 thread 通道未来重新启用时(如转为 required),机器不会重新制造死锁。 | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
| ## 规则 2:机器不得 resolve / dismiss 人类的 review thread | ||
|
|
||
| 被审者(无论人还是 agent)关闭审计意见在语义上不可接受(#81 §2.2 | ||
| 三选一中的反例)。thread 的 resolve 只属于人类 owner。 | ||
|
|
||
| ## 规则 3:机器不得自我授权 | ||
|
|
||
| 机器不得 approve PR、不得把红 check 变绿、不得替代任何确定性检查。 | ||
| 未来引入 reviewer agent(#97)时必须是 veto-only:只能把绿变红。 | ||
| 机器身份不得调用 rerun 类 API 洗掉红灯(#81 §3.4)。 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.