Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add element #1119

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix add element #1119

wants to merge 13 commits into from

Conversation

pe-pan
Copy link
Contributor

@pe-pan pe-pan commented Dec 14, 2018

Fixing issue #1118

@ionutmarisca
Copy link
Collaborator

The new Python implementation looks really good to me as it's really simple and easy to understand.

However, I would recommend creating a new flow instead of modifying the existing one so we can avoid any backwards compatibility issues.

I think adding a new Python folder under cs-content/content/io/cloudslang/base/lists/ and creating the new .sl file there should be fine.

In the future, after proper testing of the new Python implementation we can migrate all the other flows to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants