Return top-level text alongside page anchors in fragments #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills out the next iteration of support for #215 — namely returning the
"text"parameter for anchors when returning a result. This is the last step before having Pagefind calculate the correct heading for you, which will come in another PR.The way this text is extracted could be up for debate, but the chosen method seems sane. For anchors, Pagefind will use all text that is either a direct descendant of the element, or is within strictly inline elements.
For example:
will result in a
my_idanchor with the textThis title with a span!.However,
will result in a
my_idanchor with the textThis div with a!.This is to prevent having something
<body id="body">result in an anchor containing the entire page again.