Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #484: Fixed misalignment issue under 'Wrapper' section #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulsnkr
Copy link

Fixed the issue of items under the 'Wrapper' section being misaligned (issue #484).

screenshot from 2018-12-19 15-35-51

@@ -2,7 +2,7 @@ body {
overflow-x: hidden;
}

#wrapper {
#content-wrapper {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulsnkr didn't get this, why would changing the id of the css class worked for you?

Copy link
Author

@rahulsnkr rahulsnkr Dec 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram81

<div id="wrapper" className="panel-collapse collapse" role="tabpanel">
<div className="panel-body">
<PaneElement setDraggingLayer={this.props.setDraggingLayer}
handleClick={this.props.handleClick}
id="TimeDistributed_Button">Time Distributed</PaneElement>
<PaneElement setDraggingLayer={this.props.setDraggingLayer}
handleClick={this.props.handleClick}
id="Bidirectional_Button">Bidirectional</PaneElement>
</div>
</div>

The 'Wrapper' section in the pane.js file also has the same id, so the padding was being applied to that too. So I changed the id of the div in modelZoo.js, and the corresponding property name in zoo.css from 'wrapper' to 'content-wrapper'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants