Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Inception v4 to the Zoo #328

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Conversation

fenilsuchak
Copy link
Contributor

@fenilsuchak fenilsuchak commented Mar 12, 2018

This PR is for the addition of Inception_v4 model to the Zoo.
It is fundamentally different from v3 , as it has Resnets combined with Inception architecture.
As described in the paper
https://arxiv.org/abs/1602.07261
Please review

@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage remained the same at 95.442% when pulling f29f88f on Fenil3510:master into 8a9ff3d on Cloud-CV:master.

@Ram81
Copy link
Member

Ram81 commented Mar 13, 2018

@Fenil3510 can you add it to tested_models.md too

@thatbrguy
Copy link
Contributor

@Fenil3510 The tab and new-line characters in your uploaded json file are missing. Please rectify that

@fenilsuchak
Copy link
Contributor Author

@thatbrguy I have formatted the json. Please review.

@Ram81 there seems to be an issue importing the json on the fabrik cloud webpage. I tried importing/exporting on my local machine with keras/tf and It works fine.So , I cant really generate a URL for the model so that it could be put in tested_models.md.
Any suggestions?

Copy link
Contributor

@utsavgarg utsavgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fenil3510 Nice work :) Please fix the merge conflicts and also add a visualization link to the tested_models file

@Ram81
Copy link
Member

Ram81 commented Mar 15, 2018

@Fenil3510 sorry for missing this

Inception v4

formatted json

tested_model_with_source

typo
Copy link
Contributor

@utsavgarg utsavgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@utsavgarg utsavgarg merged commit c394768 into Cloud-CV:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants