Added dash footer component #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
+ Coverage 52.19% 52.29% +0.1%
=========================================
Files 60 61 +1
Lines 3148 3155 +7
Branches 367 367
=========================================
+ Hits 1643 1650 +7
Misses 1421 1421
Partials 84 84
Continue to review full report at Codecov.
|
|
@sanketbansal for all these PR's, since the Surge is not working currently, screenshots may help us to see the visual changes that you have made. |
sanketbansal
force-pushed
the
Added-Dash-Footer
branch
from
1e50ce0 to
e13f2aa
Compare
|
@lunayach @Shekharrajak @RishabhJain2018 @galipremsagar please review |
|
@sanketbansal resolve the conflicts. |
|
@sanketbansal I think that this is also not reflected. You need to call the component selector somewhere. |
sanketbansal
force-pushed
the
Added-Dash-Footer
branch
2 times, most recently
from
ea8d3a7 to
6298ef2
Compare
There was a problem hiding this comment.
@RishabhJain2018 we can also merge this now. We can scrutinize the reflection in UI when reviewing #141.
|
@sanketbansal Please resolve the conflicts here. |
|
Done |
|
@sanketbansal I think you forgot to push the changes. |
Dash footer added for improving dashboard UI
Styles added into the base.scss and dash-footer component
Removed logs and comments from dash footer component
sanketbansal
force-pushed
the
Added-Dash-Footer
branch
from
9017bac to
526dbd8
Compare
Yeah sorry Done now |
There was a problem hiding this comment.
I am not seeing the footer as the screenshot attached. Can you check in https://pr-158-evalai.surge.sh/
| this.year = new Date().getFullYear(); | ||
| const js = this.document.createElement('script'); | ||
| js.src = 'https://buttons.github.io/buttons.js'; | ||
| this.document.getElementsByTagName('head')[0].appendChild(js); |
There was a problem hiding this comment.
We should avoid using plain javascript in our Angular application. Use typescript and Angular features.
There was a problem hiding this comment.
@sanketbansal so you want to add buttons.js to use class github-button , right ?
There was a problem hiding this comment.
You can simply add script tag in html file. But I don't think you should import whole js file just to get github icon. Isn't we are already using font-awesome that has github stars and fork icons?
There was a problem hiding this comment.
it's not only github icons actually it is used to fetch number of stars and forks on the github repository also.
There was a problem hiding this comment.
Just want to let you know: If you want to manipulate any DOM element (the similar thing that you were doing -- accessing any tag) Angular have
ElementRef,ViewRef, .. reference types to pick any DOM element and modify it. There isRendererto create new elements as well.
Thanks for letting me know. I tried that but I can not get access to head tag do not know why?
Maybe because it's not a component specific element. what do you think?
|
I didn't understand why did you use plain javascript instead of Angular typescript code. |
I did not find any other method to insert script tag in the head tag. |
|
@Shekharrajak is there a way to do it? |
Commented #158 (comment) |
Added script tag in index.html file Removed javascript to append script tag into head element
|
@Shekharrajak is it okay now |
|
Just want to let you know: If you want to manipulate any DOM element (the similar thing that you were doing -- accessing any tag) Angular have |
Changes proposed in this pull request: