This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Modified challenge create page #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketbansal
force-pushed
the
modified-challengeCreate
branch
from
5bda7f0
to
d7f6c90
Compare
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=========================================
- Coverage 51.76% 51.7% -0.07%
=========================================
Files 66 66
Lines 3624 3640 +16
Branches 410 412 +2
=========================================
+ Hits 1876 1882 +6
- Misses 1653 1663 +10
Partials 95 95
Continue to review full report at Codecov.
|
|
@lunayach @Shekharrajak please review the PR. |
|
Similar commits -- #149 (comment) |
sanketbansal
force-pushed
the
modified-challengeCreate
branch
2 times, most recently
from
aa21248
to
919ea68
Compare
|
Still 37 file changes. I can't review it. Also, I see changes like other PRs. |
The file changes will get further reduce after merging #141 . I kept these changes as these are required for this PR also. |
|
Okay thanks for letting me know. |
Modified app component to show loader according to authService 'isLoader' variable.
app loader component modified to accompany AngularJS application UI.
Ported the image assets from angularJs application into 'image-port' directory
Ported styles from angularjs Application inside style-port folder
Added main.scss file of ported style in the angular.json file to compile it at the time of building project.
Added font variables in ported variable file Added font style in ported main file.
Changes made in auth services to integrate angularJS authentication features
Routing to 'auth/login' has been removed
Made the footer UI similar to the angularjs application one.
Added github fork and star button using github api
simple header added to modify the UI of the header in the dashboard
Added side bar as utility component for the side bar in the Dashboard UI
Dash footer added for improving dashboard UI
Added color property for signup button Added styles for login button
Removed ngIf condition from app-loading component to resolve the error: ExpressionChangedAfterItHasBeenCheckedError
Changes made in UI to make it look similar to current Eval AI application Changes made in challenge service to subscribe for api callback of createChallenge method. Changes made in the logic to handle the file upload and show related errors and toast.
Styles related to challenge-create component moved from 'styles-port/modules/challenge-create.scss'
Added comma after a property in angular.json file
Duplicates removed from main.scss file
Removed unused images-port folder and styles-port folder
component styles from main.scss file
Removed html-styles from simple header component Renamed styles class name in challenge create component
app loader component modified to accompany AngularJS application UI.
Added methods which are used by the components to start and stop the loader.
Added styles in base.scsss and variable.scss reqiored by loading component Added styles in loading.component.scss file
Added modifed loader styles and html
Commented lines removed from simple header file
sanketbansal
force-pushed
the
modified-challengeCreate
branch
6 times, most recently
from
486f204
to
e0ceab3
Compare
|
@lunayach this can be reviewed also. |
Removed unused styles and component folder. Removed console logs and comments.
sanketbansal
force-pushed
the
modified-challengeCreate
branch
from
e0ceab3
to
b63855b
Compare
|
@sanketbansal can you confirm if you are able to create a host team on your end. When I navigate to |
I think that issue should be resolved after merging #149 |
lunayach
reviewed
Aug 4, 2019
src/app/components/challenge-create/challenge-create.component.scss
Outdated
Show resolved
Hide resolved
lunayach
reviewed
Aug 4, 2019
src/app/components/challenge-create/challenge-create.component.html
Outdated
Show resolved
Hide resolved
lunayach
reviewed
Aug 4, 2019
src/app/components/challenge-create/challenge-create.component.html
Outdated
Show resolved
Hide resolved
lunayach
suggested changes
Aug 4, 2019
Aligned form error with text field
lunayach
approved these changes
Aug 5, 2019
RishabhJain2018
approved these changes
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: